Bug 219420 - no feedback when starting knetworkmanager (for the second time)
Summary: no feedback when starting knetworkmanager (for the second time)
Status: RESOLVED FIXED
Alias: None
Product: Network Management
Classification: Miscellaneous
Component: knetworkmanager (show other bugs)
Version: 0.9
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Will Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-20 14:01 UTC by breijs
Modified: 2011-01-30 23:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
popup if already running (2.33 KB, patch)
2010-05-05 09:37 UTC, Lamarque V. Souza
Details
notify when knm is already running (9.76 KB, patch)
2010-05-07 02:13 UTC, Lamarque V. Souza
Details
notify when knm is already running (new version) (5.97 KB, patch)
2010-05-11 21:43 UTC, Lamarque V. Souza
Details

Note You need to log in before you can comment on or make changes to this bug.
Description breijs 2009-12-20 14:01:34 UTC
Version:           0.9 (using KDE 4.3.4)
OS:                Linux
Installed from:    Ubuntu Packages

i have knetworkmanager (kmn) already started. when i run knm from the k-menu nothing happens.

i know this is understandable behavior because knm is already started... but as a simple user it took me some time to figure that out :)

a solution would be that knm shows its configuration dialog when it is started for the second time.

when it is started for the first time it could maybe also show a little splashscreen saying knm is now running in the sys tray.

thanks for knm: a welcome addition to kde ;-)
Comment 1 Will Stephenson 2010-01-05 18:00:57 UTC
Good suggestion
Comment 2 Lamarque V. Souza 2010-05-05 09:37:03 UTC
Created attachment 43261 [details]
popup if already running

This patch makes knm system tray popups if it is already running. The patch is not perfect since if the user has never clicked in the system tray icon before the popup opens as a separated window at screens's upper left corner. If the system tray icon has been clicked at least once then the popup opens at the right place but it also appears in the task manager, which is not expected.
Comment 3 Lamarque V. Souza 2010-05-07 02:13:48 UTC
Created attachment 43323 [details]
notify when knm is already running

I made another version of patch that just notifies when knm is already running. Poping up the menu is not a good idea because the mouse cursor will likely be away from the tray icon and when the user tries to reach the poped menu with the mouse the menu will disappear.
Comment 4 Lamarque V. Souza 2010-05-07 02:15:33 UTC
Comment on attachment 43323 [details]
notify when knm is already running

Just to clarify, I had to add a new public slot to NotificationManager because QTimer::singleShot cannot pass parameters to the slot.
Comment 5 breijs 2010-05-09 21:54:48 UTC
Thanks for taking the change request serious. When it is released i wil see
the function of it. I feel me not competent enough to test the changes
earlier.

Regards,

Paul

2010/5/7 Lamarque V. Souza <lamarque@gmail.com>

> https://bugs.kde.org/show_bug.cgi?id=219420
>
>
>
>
>
> --- Comment #3 from Lamarque V. Souza <lamarque gmail com>  2010-05-07
> 02:13:48 ---
> Created an attachment (id=43323)
>  --> (http://bugs.kde.org/attachment.cgi?id=43323)
> notify when knm is already running
>
> I made another version of patch that just notifies when knm is already
> running.
> Poping up the menu is not a good idea because the mouse cursor will likely
> be
> away from the tray icon and when the user tries to reach the poped menu
> with
> the mouse the menu will disappear.
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You reported the bug.
>
Comment 6 Lamarque V. Souza 2010-05-11 21:43:45 UTC
Created attachment 43488 [details]
notify when knm is already running (new version)

This is a new version of the patch, less instrusive than the first one. If nobody objects to this patch I will commit it to trunk next week.
Comment 7 Lamarque V. Souza 2010-05-18 02:53:59 UTC
SVN commit 1127909 by lvsouza:

Patch to make knm to emmit notification when it is already running.

CCBUG: 219420


 M  +1 -0      libs/service/events.cpp  
 M  +1 -0      libs/service/events.h  
 M  +6 -0      libs/service/notificationmanager.cpp  
 M  +3 -0      monolithic/CMakeLists.txt  
 M  +40 -0     monolithic/monolithic.cpp  
 M  +5 -0      monolithic/monolithic.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1127909