Bug 218906 - camera obscura/pinhole camera/vignetting effect
Summary: camera obscura/pinhole camera/vignetting effect
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Vignetting (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-16 12:03 UTC by S. Burmeister
Modified: 2016-06-29 19:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Burmeister 2009-12-16 12:03:08 UTC
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    openSUSE RPMs

Some cameras offer this effect but applying it to the original picture, i.e. not having a version without it is not the best solution.

It would be great if that effect could be added within digikam.

Things to be adjustable would be the colour of the vignette, i.e. whether the user wants a bright vignette or a dark one, the radius and the shape, i.e. rectangular, ellipse or circular.

According to http://www.flickr.com/groups/digikam/discuss/72157607665621938/ the anti-vignetting logic can be used to create such a tool.

Examples of the effect can be found here:

http://wiki.gimpforum.de/wiki/Lochkamera-Effekt
http://www.ehow.com/how_4480146_create-vignette-photoshop-elements.html
Comment 2 caulier.gilles 2010-01-11 19:27:59 UTC
Julien,

To implemente this feature, will be a 5 minutes coding.

Look here :

http://www.fourmilab.ch/netpbm/pnmctrfilt

This is the algorithm used in Antivignetting tool. Now read at "Filter Options" section :

"The -density option controls the degree of intensity attenuation by the filter at its point of maximum density. The default density is 2, which corresponds to an optical filter with a 1 f-stop filter factor. Increase the density to compensate for a greater degree of vignetting; reduce it for less. Setting the density less than 1 results in an inverse centre filter which will increase vignetting in the image."

This is want mean that if you set density less than 1, you add vignetting to image.

In digiKam tool, this settings is clamped from 1.0 to 20.0. Just changing low limit must be enough to implement this feature. Code is there :

http://lxr.kde.org/source/extragear/graphics/digikam/imageplugins/lenscorrection/vignetting/antivignettingtool.cpp#147

Simple no ?

Gilles Caulier
Comment 3 gerlos 2010-01-11 19:29:31 UTC
I'm interested too in this feature, it's actually one of the most frequent things I do outside digikam, using gimp.
Comment 4 Julien Narboux 2010-01-11 22:52:17 UTC
Gilles,

I tried to change the lower bound to 0.1 but the filter does not work for values between 0.1 and 1.0. I will try to have look.

Julien
Comment 5 Julien Narboux 2010-01-15 16:35:24 UTC
SVN commit 1075137 by jnarboux:

Add option to add vignetting.
Fix radius slider whose range was too large.

CCBUGS: 218906 177827




 M  +23 -11    antivignetting.cpp  
 M  +4 -1      antivignetting.h  
 M  +54 -32    antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075137
Comment 6 Julien Narboux 2010-01-17 09:23:26 UTC
SVN commit 1075994 by jnarboux:

Prevent overflow, factorize code.
There is still a bug when adding vignetting when radisus is smaller than 1.0.

CCBUGS: 218906, 177827


 M  +37 -11    antivignetting.cpp  
 M  +5 -0      antivignetting.h  
 M  +3 -3      antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075994
Comment 7 Julien Narboux 2010-01-17 10:20:29 UTC
SVN commit 1076003 by jnarboux:

Fix bug when radius is small, polish.

CCBUG: 218906
CCBUG: 177827
FEATURE: 218906



 M  +1 -1      antivignetting.cpp  
 M  +1 -1      antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1076003
Comment 8 Julien Narboux 2010-01-18 08:17:42 UTC
SVN commit 1076407 by jnarboux:

Add TODO file for the vignetting tool.

CCBUG: 218906
CCBUG: 177827




 A             TODO  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1076407