Bug 218889 - inconsistent ui element sizing
Summary: inconsistent ui element sizing
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Ergonomy (show other bugs)
Version: 1.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-16 07:42 UTC by Jens Mueller
Modified: 2017-08-04 21:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.0.0


Attachments
tagsidebar (38.52 KB, image/png)
2009-12-16 07:43 UTC, Jens Mueller
Details
gpssidebar (40.37 KB, image/png)
2009-12-16 07:43 UTC, Jens Mueller
Details
PATCH for imagedescedittab (1.60 KB, patch)
2009-12-16 17:38 UTC, Jens Mueller
Details
PATCH for imagepropertiesgpstab (872 bytes, application/octet-stream)
2009-12-16 17:39 UTC, Jens Mueller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Mueller 2009-12-16 07:42:25 UTC
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    Ubuntu Packages

in gpssidebar and tagsidebar some ui elements do explizit sizing to a smaller height. This looks somehow inconsistent (also icon height do not fit button height). Perhaps there is a real reason for doing this, in this case this bug should be rejected - otherwise the explizit sizing should be removed. Please look at the screenshots and at imagedescedittab.cpp(234, 240, 247) and imagepropertiesgpstab.cpp(156).
Comment 1 Jens Mueller 2009-12-16 07:43:15 UTC
Created attachment 39084 [details]
tagsidebar
Comment 2 Jens Mueller 2009-12-16 07:43:51 UTC
Created attachment 39085 [details]
gpssidebar
Comment 3 caulier.gilles 2009-12-16 08:04:25 UTC
There is no specific reason for that, excepted hacking with old KDE theme to optimize space which give side effect in code now.

I'm waiting patch to fix it (:=)))

Gilles Caulier
Comment 4 Jens Mueller 2009-12-16 17:38:36 UTC
Created attachment 39099 [details]
PATCH for imagedescedittab
Comment 5 Jens Mueller 2009-12-16 17:39:11 UTC
Created attachment 39100 [details]
PATCH for imagepropertiesgpstab
Comment 6 caulier.gilles 2009-12-16 23:19:45 UTC
SVN commit 1063080 by cgilles:

fix gui sizing
BUGS: 218889


 M  +0 -4      imagedescedittab.cpp  
 M  +0 -1      imagepropertiesgpstab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1063080