Bug 217601 - kunitconversion - millimeters of mecrury (mmHg) missing
Summary: kunitconversion - millimeters of mecrury (mmHg) missing
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 4.3
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Petri Damstén
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-06 16:23 UTC by Andrey Borzenkov
Modified: 2010-02-17 09:01 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch to add mmHg units to kunitconversion (1.54 KB, patch)
2009-12-11 16:19 UTC, Andrey Borzenkov 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Borzenkov 2009-12-06 16:23:42 UTC 
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Standard unit for atmospheric pressure in Russia is millimetres of mercury (mmHg). This is missing as of current 4.4 beta. Are there reasons to not add it? Will patch be accepted?
Comment 1 Michael Pyne 2009-12-06 21:35:37 UTC 
I've heard of the unit, I'm sure it's merely an oversight. If you have a patch let's see it. :)
Comment 2 Anne-Marie Mahfouf 2009-12-07 08:33:16 UTC 
Yes it would be good to have the patch so this is not forgotten for 4.5 (not allowed to add new strings in 4.4)
Comment 3 Andrey Borzenkov 2009-12-11 16:19:23 UTC 
Created attachment 38992 [details]
Patch to add mmHg units to kunitconversion

Patch attached. Unfortunately I do not have infrastructure to actually build it.
Comment 4 John Layt 2009-12-11 17:45:24 UTC 
Need to assign to petri.damsten@gmail.com as author/maintainer of code, but he doesn't seem to be registered as yet.  I'll cc: him.

I'll also get Petri to raise a request in bugzilla against bugs.kde.org to request adding a KUnitConverter category to kdelibs Product, with default assignment to Petri.
Comment 5 Petri Damstén 2010-02-17 09:01:40 UTC 
SVN commit 1091623 by pdamsten:

Add millimeters of mecrury (mmHg)
patch from Andrey Borzenkov
BUG: 217601

 M  +1 -1      converter.h  
 M  +12 -3     pressure.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1091623