Bug 216491 - camera interface view does not work to preview movies
Summary: camera interface view does not work to preview movies
Alias: None
Product: digikam
Classification: Applications
Component: Import-Gphoto2 (show other bugs)
Version: 3.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
Depends on:
Reported: 2009-11-28 11:56 UTC by Philippe ROUBACH
Modified: 2017-08-16 06:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 3.0.0


Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2009-11-28 11:56:00 UTC
Version:           inconnu (using 4.3.77 (KDE 4.3.77 (KDE 4.4 >= 20091123)), Mandriva Linux release 2010.1 (Cooker) for i586)
Compiler:          gcc
OS:                Linux (i686) release

digikam 1.0.0b6
kipi-plugins 0.8

go to import/cameras

photos and movies  icons are displayed
select a movie
click on "view" button
you have an error message :

failed to load image
Comment 1 caulier.gilles 2009-11-28 12:07:44 UTC
Install mplayerthumbs package and all will be fine...

Video thumbs generation is delegate to KDE framework.

Gilles Caulier
Comment 2 caulier.gilles 2009-11-28 12:11:21 UTC
View option only play with image, using editor. It doesn't play movies for the moment, using Phonon...

Gilles Caulier
Comment 3 Philippe ROUBACH 2009-11-28 13:44:16 UTC
1. ok thanks i made this report because
in digikam if you select a movie then click "view" button then this launch the movie player

i was expected same feature in kameraklient

it's inconsistent

2. i installed mplayerthumbs and mplayer and win32 codecs

in dolphin now i have a preview thumbnail in the right panel
but no preview thumbnail icon for the file in dolphin or in kameraclient
just the standard movie icon
Comment 4 Philippe ROUBACH 2009-11-28 15:25:30 UTC
ok now i understand your principles

is it possible to open a film editor if one is installed ?
Comment 5 Philippe ROUBACH 2009-11-28 17:23:16 UTC

now i have preview icon for movie everywhere
- in dolphin the file list and in the right panel
- in digikam in window showing album contents

but not in camera gui
 is it a kde camera protocol pb or a digikam pb ?
Comment 6 caulier.gilles 2009-11-28 17:37:03 UTC
How do you have fixed movies icons preview with maplyersthumbs. With new Mandriva 2010.0, no thumbs are generated for video in icon view ?

About cameragui, it can be relevant of your camera driver : Gphoto do not support video thumb extraction. With UMS camera and digiKam driver, no problem.

Comment 7 Philippe ROUBACH 2009-11-28 17:55:55 UTC
ok thanks for explanation

for complete activation of preview icon for movie


sorry it's in french
Comment 8 Philippe ROUBACH 2009-12-06 11:36:39 UTC
i complete the pb definition (see description)

the default filter is "all images" it must be "all images and movies"

you can select movie by typing *.* as default filter
Comment 9 Philippe ROUBACH 2009-12-26 20:37:59 UTC
digikam 1.0.0
kipi-pluigins 1.0.0

pb still there

you cannot select a movie due to filter "all images"
when you use *.* filter you can select a movie
but there is no preview for movie (yes there is preview in dolphin)

for no movie preview in dolphin selector i assume this is a dolphin pb not a digikam one

see comment #8
Comment 10 Philippe ROUBACH 2009-12-26 21:38:19 UTC
ignore my comment #8 and 9
it's about another bug

digikam 1.0.0
kipi-plugins 1.0.0

pb still there : for a movie an image application is launched instead of a movie editor
Comment 11 Philippe ROUBACH 2010-04-08 14:02:42 UTC
digikam 1.2
kipi-plugins 1.2

pb still there : for a movie an image application is launched instead of a
movie editor or a movie viewer
Comment 12 caulier.gilles 2011-08-03 14:52:39 UTC
*** Bug 225151 has been marked as a duplicate of this bug. ***
Comment 13 Islam Wazery 2012-08-23 03:13:47 UTC
Git commit 593806836c8c26a9df718394ffc39fd3cb639d37 by Islam Wazery.
Committed on 23/08/2012 at 04:42.
Pushed by wazery into branch 'development/3.0.0'.

Added mediaplayer view to import interface

M  +1    -0    utilities/importui/CMakeLists.txt
M  +4    -11   utilities/importui/views/importiconview.cpp
M  +1    -3    utilities/importui/views/importiconview_p.h
M  +28   -34   utilities/importui/views/importstackedview.cpp
M  +2    -2    utilities/importui/views/importstackedview.h
M  +1    -1    utilities/importui/views/importview.cpp
A  +306  -0    utilities/importui/views/mediaplayerview.cpp     [License: GPL (v2+)]
A  +107  -0    utilities/importui/views/mediaplayerview.h     [License: GPL (v2+)]

Comment 14 Islam Wazery 2012-08-23 03:14:52 UTC
I implemented a mediaplayer preview for import tool, I will fix the issue of movies thumbnail loading ASAP.
Comment 15 Philippe ROUBACH 2012-08-23 07:19:18 UTC
Comment 16 caulier.gilles 2012-08-23 08:04:20 UTC

I take a look to your ImportUI mediaplayerview implementation and a lots of code are redondant with AlbumGUI mediaplayerview.

We need to factorize this code. The difference is that ImportUI use CameraInfo where AlbumGUI use ImageInfo containers.

But the code to wrap Phonon widget to host GUI is the same.

What do you think about ?

Gilles Caulier
Comment 17 caulier.gilles 2012-08-23 10:56:00 UTC
Git commit d38b2e188ddde0e04b5526847829889ba463ab09 by Gilles Caulier.
Committed on 23/08/2012 at 12:54.
Pushed by cgilles into branch 'development/3.0.0'.

base MediaPlayer class on KUrl, not ImageInfo or CameraImageInfo, for future factoring

M  +4    -6    digikam/views/mediaplayerview.cpp
M  +3    -8    digikam/views/mediaplayerview.h
M  +3    -3    digikam/views/stackedview.cpp
M  +3    -3    utilities/importui/views/importstackedview.cpp
M  +4    -6    utilities/importui/views/mediaplayerview.cpp
M  +3    -7    utilities/importui/views/mediaplayerview.h

Comment 18 Islam Wazery 2012-08-23 11:29:02 UTC
Thanks Gilles for factorizing it, I reused albumgui mediaplayerview now.
Comment 19 caulier.gilles 2012-08-23 11:44:22 UTC

I think a similar factoring can be done with ImagePreviewView and ImportPreviewView.

If you are agree, i can take a look...

Gilles Caulier
Comment 20 Islam Wazery 2012-08-23 11:58:04 UTC
Sure Gilles, If you have more important thing to do I can handle it.
Comment 21 caulier.gilles 2012-08-23 12:06:03 UTC
I will review it both classes. there is always code to check and polish. I will give you a feedback accordingly...

Comment 22 caulier.gilles 2012-08-23 12:25:14 UTC
Both class can be factored. Not sure that all methods can be considerated as common, like with mediaplayer classes. This depend of which features can be implemented in ImportUI as AlbumGUI, as face tag for ex.

At least, i recommend to factorize all that you can in a common and parents class, and just implement necessary code to childrens classes.

Question : what's about image rotation in ImportUI ? It have a sense to rotate item as well in Import icon--iew and preview mode, as it will done automatically at download time ? Also, to rotate item using FileActionMngr with GPhoto2 camera will not work (excepted if you download it previously and upload back to camera (:=))))

Gilles Caulier
Comment 23 Islam Wazery 2012-08-24 14:19:58 UTC
Git commit bb09c7272caa0dddb7556ce8d96ecad8ffd27f6e by Islam Wazery.
Committed on 24/08/2012 at 16:18.
Pushed by wazery into branch 'development/3.0.0'.

Removed view item option (alternate is preview mode) and fixed thumbnail issue for files other than images.
Now all files other than images have an icon representing their types,
the video files with thumbnails "THM files" are loaded correctly.
Is that enough for this B.K.O?

M  +6    -60   utilities/importui/backend/cameracontroller.cpp
M  +1    -3    utilities/importui/backend/cameracontroller.h
M  +29   -29   utilities/importui/items/importdelegate.cpp
M  +1    -32   utilities/importui/main/cameraui.cpp
M  +0    -3    utilities/importui/main/cameraui.h
M  +0    -1    utilities/importui/main/cameraui.rc
M  +0    -2    utilities/importui/main/cameraui_p.h
M  +0    -1    utilities/importui/views/importiconview.cpp
M  +0    -1    utilities/importui/views/importpreviewview.cpp
M  +1    -1    utilities/importui/views/importstackedview.cpp

Comment 24 Islam Wazery 2012-08-24 16:38:16 UTC
Philippe can you test the new import tool from development/3.0.0 branch and tell me if this report is still valid.
Comment 25 Islam Wazery 2012-08-31 01:54:17 UTC
I think this report can be closed now.