Bug 216019 - can't deal with datasources with more than MAX_INT samples
Summary: can't deal with datasources with more than MAX_INT samples
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.8.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Andrew Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-24 23:27 UTC by Netterfield
Modified: 2010-01-26 02:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Netterfield 2009-11-24 23:27:56 UTC
Version:           1.7.0 (using 3.5.10 "release 21.9" , openSUSE )
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.27.37-0.1-pae

Kst can not load data past frame MAX_INT, since ints are used to reference frame numbers.

Plank HFI now has more than MAX_INT frames.  LFI may also reach that point.

Ideally, frame numbers would be stored and referenced by 64 bit integers.

NOTE: kst does not need to be able to read more than MAX_INT samples.  It just has to be able to find samples within a data source that has more than MAX_INT samples.
Comment 1 D. V. Wiebe 2009-11-24 23:46:06 UTC
This is what off_t was invented for.
Comment 2 Andrew Walker 2009-12-04 01:59:26 UTC
Hi Barth,

Do you know where I can get the necessary header files, etc that I would need to build the dmc datasource. I don't want to check in code that isn't going to compile.

Thanks, 

Andrew.
Comment 3 Andrew Walker 2009-12-14 21:26:02 UTC
SVN commit 1062454 by arwalker:

CCBUG:216019 add ability for datasources to handle more than INT_MAX samples

 M  +16 -2     extensions/js/bind_datavector.cpp  
 M  +110 -8    libkst/kstdatasource.cpp  
 M  +12 -9     libkst/kstdatasource.h  
 M  +1 -1      libkst/kstobject.h  
 M  +45 -42    libkst/kstrvector.cpp  
 M  +13 -13    libkst/kstrvector.h  
 M  +4 -0      libkst/stdinsource.cpp  
 M  +28 -13    libkstapp/kstchangenptsdialog_i.cpp  
 M  +10 -4     libkstapp/kstdatawizard_i.cpp  
 M  +7 -6      libkstapp/kstdatawizard_i.h  
 M  +30 -20    libkstapp/kstvectordialog_i.cpp  
 M  +0 -1      libkstapp/kstviewellipse.cpp  
 M  +1 -1      libkstapp/kstviewvectorsdialog_i.h  
 M  +3 -3      libkstapp/statuslabel.cpp  
 M  +125 -119  widgets/datarangewidget.ui.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1062454
Comment 4 Andrew Walker 2009-12-15 22:54:06 UTC
SVN commit 1062768 by arwalker:

CCBUG:216019 change readField to readFieldSkip in the datasources that implement it

 M  +1 -1      nad/nadsource.cpp  
 M  +1 -1      nad/nadsource.h  
 M  +1 -1      naddirect/naddirect.cpp  
 M  +1 -1      naddirect/naddirect.h  
 M  +1 -1      planck/planck.cpp  
 M  +1 -1      planck/planck.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1062768
Comment 5 Andrew Walker 2010-01-08 19:06:26 UTC
SVN commit 1071779 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +88 -31    dmc.cpp  
 M  +14 -30    dmc.h  
 M  +8 -5      dmcdata.cpp  
 M  +11 -12    dmcdata.h  
 M  +38 -24    dmcobj.cpp  
 M  +5 -12     dmcobj.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071779
Comment 6 Andrew Walker 2010-01-08 20:11:13 UTC
SVN commit 1071791 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +6 -5      dmc.cpp  
 M  +4 -4      dmcdata.h  
 M  +1 -1      dmcobj.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071791
Comment 7 Andrew Walker 2010-01-09 00:24:32 UTC
SVN commit 1071888 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +20 -16    kstdatawizard_i.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071888
Comment 8 Andrew Walker 2010-01-09 00:38:15 UTC
SVN commit 1071895 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +1 -1      kstdatawizard_i.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071895
Comment 9 Andrew Walker 2010-01-09 00:52:47 UTC
SVN commit 1071905 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +19 -3     datarangewidget.ui.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071905
Comment 10 Andrew Walker 2010-01-11 19:40:50 UTC
SVN commit 1073157 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +0 -2      dmc.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1073157
Comment 11 Andrew Walker 2010-01-11 20:45:00 UTC
SVN commit 1073182 by arwalker:

CCBUG:216019 first draft of changes to dmc datasource

 M  +1 -1      Makefile.am  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1073182
Comment 12 Andrew Walker 2010-01-26 02:19:52 UTC
Feedback from HFI team together with local testing indicates that the changes had the desired effect with no negative repercussions.