Bug 215663 - Composer/HTML mode: indentation increase doesn't work
Summary: Composer/HTML mode: indentation increase doesn't work
Status: CONFIRMED
Alias: None
Product: kmail2
Classification: Applications
Component: composereditor-ng (show other bugs)
Version: 5.4.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-22 13:29 UTC by S.Trzmiel
Modified: 2018-10-12 11:31 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of KMail Composer (42.40 KB, image/png)
2010-03-15 21:55 UTC, Jörg von Frantzius
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S.Trzmiel 2009-11-22 13:29:16 UTC
Version:           1.12.2 (using KDE 4.3.2)
OS:                Linux
Installed from:    Fedora RPMs

As in summary, one can't increase indentation with button from toolbar. I guess indent. decrease does not work also, but can't try because there's no indentation to decrease ;)

Steps to reproduce:

1. Open KMail composer and enable HTML formatting in options menu.
2. Set text cursor in message edition window and click "increase indentation" button.

Actual result:
 Cursor (or selected row of text) stays glued to the left edge of window

Expected result:
  Selected text and/or cursor moves right/left according to the increase/decrease indentation.
Comment 1 Jörg von Frantzius 2010-03-15 21:55:43 UTC
Created attachment 41671 [details]
Screenshot of KMail Composer
Comment 2 Jörg von Frantzius 2010-03-15 21:56:33 UTC
Same here, on KDE 4.4.1 and both with Ubuntu 9.10 and openSUSE 11.2.

For me, the buttons are disabled, i.e. there is no mouse-over effect and they seem to be greyed out (see attachment)
Comment 3 Ricardo Graça 2010-11-21 14:35:24 UTC
It's still an issue with KDE 4.5.3.
Comment 4 S.Trzmiel 2010-11-21 14:51:13 UTC
Actuilaly in KMail 1.13.5 this buttons works but description is misleading.
It makes paragraph a bullet/numbered list. So we're still stukc with entering lots of spaces to adjust text position related to the window.
Yeah, I know real man write mail in text mode, but....
Comment 5 Laurent Montel 2015-04-12 09:55:34 UTC
Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.
Comment 6 S.Trzmiel 2015-04-12 16:06:14 UTC
KMail  4.14.6 - comment #4 is still valid. Increase/decrease indentation buttons enable/disable bullet list.
Comment 7 Denis Kurz 2017-01-13 22:28:13 UTC
This is still valid in 5.4.1. The buttons work as intended, but the tooltip is misleading. I can't come up with a good one, however. "Enable/disable bullet list" doesn't fit either, because you can also create sublists with this button, like this:

  * A
    * A1
    * A2
      * A2i
  * B
  * C
    * C1
...

On unindented text, it makes the current line a list item of a new list. On a list item x, it increases the indentation/nestedness level by one if it is preceded by a list item whose level is at least the level of x.

A context-sensitive tooltip could help here. "Make list item" for unindented text; "Make sublist item" for already indented text. Something like that. The "decrease indentation" tooltip would have to be adapted accordingly.
Comment 8 beojan 2017-03-31 09:50:20 UTC
(In reply to Denis Kurz from comment #7)
> This is still valid in 5.4.1. The buttons work as intended, but the tooltip
> is misleading. I can't come up with a good one, however. "Enable/disable
> bullet list" doesn't fit either, because you can also create sublists with
> this button, like this:
> 

I'd suggest Increase List Level and Decrease List Level.
Comment 9 Matthias Nagel 2018-10-02 16:40:59 UTC
Please rename the command/tool tip as suggested. Something like "Increase/Decrease List Level" sounds good. This should be an easy, quick fix and helps to reduce the confusion.

Additionally, one might consider to enable the command if and only if the cursor is placed inside a list and deactivate the command otherwise. This would force the user to create a list first and could lessen confusion further.

Nonetheless, there should be also a feature to create left (and right) indention without a blocklist. There are two other feature requests that are loosely related, see bugs #341961 and #362493.
Comment 10 Laurent Montel 2018-10-12 11:31:17 UTC
I renamed actions.