Bug 215519 - kmail improperly makes path name italic
Summary: kmail improperly makes path name italic
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kpimutils (show other bugs)
Version: 4.4
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-21 06:20 UTC by Andrey Borzenkov
Modified: 2009-12-15 16:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Example of manged path name (10.73 KB, image/png)
2009-11-21 06:21 UTC, Andrey Borzenkov
Details
bugfix (660 bytes, patch)
2009-11-23 13:37 UTC, Julien Richard-Foy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Borzenkov 2009-11-21 06:20:45 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

See screenshot. In the

/etc/{rsyslog.d,syslog-ng.d}/package.rpmnew

the first two slashes are gone and etc is shown in italic. This is rather confusing.
Comment 1 Andrey Borzenkov 2009-11-21 06:21:24 UTC
Created attachment 38469 [details]
Example of manged path name
Comment 2 Martin Koller 2009-11-21 13:58:03 UTC
I can not reproduce this with KDE 4.3.3
Which version of kmail are you using ?
Comment 3 Andrey Borzenkov 2009-11-21 15:12:29 UTC
1.12.90
KDE 4.3.75 (KDE 4.3.75 (KDE 4.4 >= 20091113))

Would you be so kind to reopen it because it was closed incorrectly? And yes, as you have seen, it is a regression in 4.4.
Comment 4 Julien Richard-Foy 2009-11-23 13:37:18 UTC
Created attachment 38523 [details]
bugfix

This patch forbids text highlighting unless highlighting markups are followed by whitespaces (previous behavior restored).
Comment 5 Thomas McGuire 2009-12-08 12:50:03 UTC
This test breaks 3 unit tests, for example the case "*BLA BLA BLA BLA*.".

Please have a look at those and modify the patch so that they still pass.

The new unit test for this case would be:

QTest::newRow( "" ) << "the /etc/{rsyslog.d,syslog-ng.d}/package.rpmnew file" << 0x09 << "the /etc/{rsyslog.d,syslog-ng.d}/package.rpmnew file";
Comment 6 Julien Richard-Foy 2009-12-08 13:19:58 UTC
I know it breaks these tests, I said it before: the old behaviour is restored, so highlighting marks can *not* be followed by punctuation marks.
Comment 7 Thomas McGuire 2009-12-08 13:55:36 UTC
Oh sorry, I didn't read closely enough, then.
Could you also update the test, then, either by uncommenting the failing tests or by marking them with QEXCEPT_FAIL?
Comment 8 Thomas McGuire 2009-12-15 16:50:58 UTC
Committed with r1062666, thanks.