Bug 215190 - paging of search results does not work
Summary: paging of search results does not work
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kldap (show other bugs)
Version: 4.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 23:28 UTC by Mark Eaton
Modified: 2009-12-19 22:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Changes to allow paging of results to work (4.18 KB, patch)
2009-11-18 23:30 UTC, Mark Eaton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Eaton 2009-11-18 23:28:36 UTC
Version:            (using KDE 4.3.3)
OS:                Linux
Installed from:    Ubuntu Packages

If you specify paging when doing a search there are two bugs whic prevent it from working.
Firstly the multiple paging controls are added to the request causing it to be rejected.
Secondly if you fix the first problem an error occurs because the reference message is handled incorrectly.

I will attached a patch against the 4.3.3 release/branch which makes it all work.
Comment 1 Mark Eaton 2009-11-18 23:30:18 UTC
Created attachment 38434 [details]
Changes to allow paging of results to work

This patch does 3 things.
1. It prevents adds a function to set a control which should only be present once.
2. Disabled auto following of referals
3. Ignores the referal messages.
Comment 2 Christophe Marin 2009-11-19 00:23:00 UTC
Can you post your patch to http://reviewboard.kde.org please ? (choose the 'kdepim' group)
Comment 3 Mark Eaton 2009-11-19 10:05:21 UTC
posted http://reviewboard.kde.org/r/2212/
Comment 4 Allen Winter 2009-12-19 22:05:34 UTC
SVN commit 1064010 by winterz:

add a new static function  LdapControl::insert() (formerly reviewed as
LdapControl::setUniqueControl()) and use it to allow paging in search results
Fixed For: KDE SC 4.4
BUG: 215190

http://reviewboard.kde.org/r/2212/

thanks marke, please close the review as submitted.

MERGE: none (cannot backport due to new public method)



 M  +15 -0     ldapcontrol.cpp  
 M  +12 -3     ldapcontrol.h  
 M  +5 -1      ldapoperation.cpp  
 M  +5 -4      ldapsearch.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1064010