Bug 213637 - KDatePicker widget does not support RTL languages
Summary: KDatePicker widget does not support RTL languages
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdeui (show other bugs)
Version: 4.3
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: John Layt
URL:
Keywords: rtl
: 187412 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-08 05:16 UTC by Zayed Al-Saidi
Modified: 2010-06-06 18:10 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zayed Al-Saidi 2009-11-08 05:16:53 UTC
Version:            (using KDE 4.3.3)
Installed from:    openSUSE RPMs

The KDatePicker widget does not correctly display in RTL mode, the cells in the table go LTR instead. 

For detail see: bug #182976
Comment 1 Christoph Feck 2009-12-08 23:45:39 UTC
John, I would like to rewrite the rendering of KDateTable to fix more issues it has (rounding problems, font size problems, and rendering speed on updates).

One question that remains is the content of the day cells. Are they guaranteed to be two digits wide? If not, how can I compute the widest possible cell? Current code re-adjust the size hint during rendering, which looks like a hack...
Comment 2 John Layt 2009-12-09 00:23:24 UTC
Cool.  So have you started this already?  Is this for 4.4?  If so I'll be happy for you to include this too.  I was just about to start on it as I've finished the Plasma one, and was thinking if I needed to simplify the date to/from position calculations like I did in Plasma.

I think it is safe to assume 2 digits per cell, I can't think of any common Calendar System we'd support with more than 30-something days in a month.
Comment 3 John Layt 2010-02-01 14:01:02 UTC
*** Bug 187412 has been marked as a duplicate of this bug. ***
Comment 4 John Layt 2010-06-03 22:55:35 UTC
Christoph, did you make any progress on this, or should I attempt a bug fix for 4.5?
Comment 5 John Layt 2010-06-06 17:10:10 UTC
SVN commit 1135145 by jlayt:

Fix KDatePicker/KDateTable to display correctly in RTL mode.

CCBUG: 213637

To be backported.



 M  +18 -1     kdatetable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1135145
Comment 6 John Layt 2010-06-06 17:26:53 UTC
SVN commit 1135154 by jlayt:

Backport RTL fix for KDatePicker/KDateTable

Backport form trunk of revision 1135145

BUG: 213637



 M  +18 -1     kdatetable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1135154
Comment 7 Zayed Al-Saidi 2010-06-06 17:39:26 UTC
Thanks John for fixing this issue.
Comment 8 Dotan Cohen 2010-06-06 18:10:43 UTC
Thanks!