Bug 213206 - Okular does not save bookmarks if logout from KDE requested
Summary: Okular does not save bookmarks if logout from KDE requested
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-05 09:23 UTC by Andrea Cimino
Modified: 2009-12-26 17:57 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Cimino 2009-11-05 09:23:49 UTC
Version:            (using KDE 4.3.3)
OS:                Linux
Installed from:    Ubuntu Packages

Suppose i am reading a PDF, and i want to bookmark
a particular page. So i add a bookmark. Later i quit KDE
from the logout button, without closing okular by hand.
So okular should receive a kind of TERM signal i think.
Well, the only way to make okular remind to save the bookmarks
is closing the application by hand, otherwise my bookmarks
are lost. This is always reproducible, at least for me.
Comment 1 Pino Toscano 2009-12-26 17:57:12 UTC
SVN commit 1066286 by pino:

Change the saving strategy for bookmarks: instead of saving them manually or at closing, save them after each action.
This should avoid any bookmark loss due to premature crash or similar abnormal closing.
BUG: 157246
BUG: 213206
Also, the above change triggers the D-Bus synchronisation of the internal bookmark manager of the various Okular instances;
react to those changes properly by updating the own info (because of the changes in the bookmark manager of another instance).
BUG: 216239

On the technical note, keep the cache of known file just with the bookmark address instead of the group itself
(which gets changed behind our back).


 M  +98 -25    bookmarkmanager.cpp  
 M  +2 -0      bookmarkmanager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1066286