Version: 4.3.73 (using Devel) Compiler: Sun Studio 12 U1 OS: Solaris Installed from: Compiled sources build on OpenSolaris b125 with SunStudio 12 U1 fails with: ... "/export/home/hajma/packages/BUILD/kdebase-workspace-4.3.73svn1040395/ksysguard/gui/SensorDisplayLib/SignalPlotter.cc", line 143: Error: The function "isinf" must have a prototype. "/export/home/hajma/packages/BUILD/kdebase-workspace-4.3.73svn1040395/ksysguard/gui/SensorDisplayLib/SignalPlotter.cc", line 154: Error: The function "isinf" must have a prototype. "/export/home/hajma/packages/BUILD/kdebase-workspace-4.3.73svn1040395/ksysguard/gui/SensorDisplayLib/SignalPlotter.cc", line 827: Error: The function "isinf" must have a prototype. "/export/home/hajma/packages/BUILD/kdebase-workspace-4.3.73svn1040395/ksysguard/gui/SensorDisplayLib/SignalPlotter.cc", line 831: Error: The function "isinf" must have a prototype. 4 Error(s) and 1 Warning(s) detected. from what I gathered searching the web, isinf is not really portable across platforms. See the mysql bug and patch at http://bugs.mysql.com/bug.php?id=28240
Created attachment 38045 [details] patch actually the mysql link is wrong as well, 'finity' is not part of the C++standard either. Here's my patch, practically taken from http://bytes.com/topic/c/answers/588254-how-check-double-inf-nan
Doesn't your my_isinf function return the exact opposite? It returns true if the number is finite.
damn, right, too late in the night, I only cared if it compiles. sorry
Created attachment 38093 [details] better patch This one should be better. What would be the best way to verify the code works as expected? where in ksysguard should I go? TIA
> This one should be better. What would be the best way to verify the code works > as expected? where in ksysguard should I go? TIA The graphs should be drawn in the second tab. Also the unit tests should pass: cd build/kdebase/workspace/ksysguard/gui/tests (or wherever your build directory is) make buildtests make tests They should all pass.
On Solaris, I think the correct approach is through ieeefp -- which is done in several other places in the KDE sources: #include <ieeefp.h> int finite(double dsrc);
perhaps something like #if defined(HAVE_IEEEFP_H) && defined(__SUNPRO_CC) #include <ieeefp.h> #define isinf !finite #endif ? with check_include_files(ieeefp.h HAVE_IEEEFP_H) in some CMakeLists.txt ?
also there is some reference: http://markmail.org/thread/5fpgbdzu5ala3ley
tropikhamjma, any chance of a finished patch that I can commit?
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone!
Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone!
Can you reproduce this issue with current version of ksysguard?
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!