Version: 0.8.0-svn r1041223 (using KDE 4.3.1) Compiler: gcc 4.3.4 OS: Linux Installed from: Debian testing/unstable Packages As already pointed out in bug 197899 (https://bugs.kde.org/show_bug.cgi?id=197899#c2) the sorting funtion in the rename images dialog does not work. This is still true for 0.8.0-svn r1041223.
Created attachment 37922 [details] Patch fixing the sorting A detailed description of the changes is available in the beginning of the patch file.
Thanks Martin. I will review your patch tomorow morning. Gilles Caulier
SVN commit 1041769 by cgilles: apply patch #37922 by Martin EngelMann. Comments from Martin : "For this fix a hidden column is created in the BatchProcessImagesList that holds the sort key for the BatchProcessImagesItems. This sort key is created based on the selected sorting criterium. The already present part of the interface in BatchProcessImagesItem has been replaced by get and set function for the sortkey. The column of the sortkey is made available by the static function columnOfSortKey. In batchprocessimageslist.cpp:44 the index of the column with the sort key is used instead of calling the static function to avoid an include dependency with batchprocessimagesitem.h. If this doesn't hurt. The function should be called instead of using the magic number. I've deleted the already commented out function BatchProcessImagesItem::compare because I don't see any further use of it." BUGS: 212116 M +2 -1 CMakeLists.txt M +16 -21 batchprocessimagesitem.cpp M +4 -7 batchprocessimagesitem.h M +2 -1 batchprocessimageslist.cpp M +4 -8 renameimageswidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1041769
Hi Gilles, thank you for your support and the quick merge. Regards, Martin Am Mittwoch 28 Oktober 2009 14:41:36 schrieb Gilles Caulier: > https://bugs.kde.org/show_bug.cgi?id=212116 > > > Gilles Caulier <caulier.gilles@gmail.com> changed: > > What |Removed |Added > --------------------------------------------------------------------------- > - Status|UNCONFIRMED |RESOLVED > Resolution| |FIXED > > > > > --- Comment #3 from Gilles Caulier <caulier gilles gmail com> 2009-10-28 > 14:41:33 --- SVN commit 1041769 by cgilles: > > apply patch #37922 by Martin EngelMann. > > Comments from Martin : > > "For this fix a hidden column is created in the BatchProcessImagesList that > holds > the sort key for the BatchProcessImagesItems. This sort key is created > based on the selected sorting criterium. > > The already present part of the interface in BatchProcessImagesItem has > been replaced by get and set function for the sortkey. The column of the > sortkey is made available by the static function columnOfSortKey. > > In batchprocessimageslist.cpp:44 the index of the column with the sort key > is used instead of calling the static function to avoid an include > dependency with batchprocessimagesitem.h. If this doesn't hurt. The > function should be called instead of using the magic number. > > I've deleted the already commented out function > BatchProcessImagesItem::compare because I don't see any further use of > it." > > BUGS: 212116 > > > > M +2 -1 CMakeLists.txt > M +16 -21 batchprocessimagesitem.cpp > M +4 -7 batchprocessimagesitem.h > M +2 -1 batchprocessimageslist.cpp > M +4 -8 renameimageswidget.cpp > > > WebSVN link: http://websvn.kde.org/?view=rev&revision=1041769 >
It's alawyas a pleasure to review your patch. Please continue like this. Note : BatchProcessImages plugins is now a pure Qt4 implementation (after a million of commits). Please test it on you computer if you see regression... Gilles