Bug 210956 - Zoom slider looks not centered with Oxygen style [patch]
Summary: Zoom slider looks not centered with Oxygen style [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Ergonomy (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-18 11:54 UTC by Ignat Semenov
Modified: 2017-08-06 08:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0
Sentry Crash Report:


Attachments
proposed patch (802 bytes, patch)
2009-10-18 11:56 UTC, Ignat Semenov
Details
patch #2 (636 bytes, patch)
2009-10-18 16:19 UTC, Ignat Semenov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ignat Semenov 2009-10-18 11:54:38 UTC
Version:            (using Devel)
Compiler:          gcc 4.4.1 
OS:                Linux
Installed from:    Compiled sources

When using Oygen widget style, the zoom slider looks off-center a few pixels. It does, however, look fine when using other styles. I've taken a look into the code and found the guilty line. In Dolphin, the code for setting up the zoom slider and buttons is identical, but doesn't include this line. I've got no clue why it's there, but removing it really helps.
Comment 1 Ignat Semenov 2009-10-18 11:56:50 UTC
Created attachment 37645 [details]
proposed patch
Comment 2 Andi Clemens 2009-10-18 12:19:48 UTC
Right, this doesn't make sense. I'll apply your patch! Thanks...
Comment 3 Andi Clemens 2009-10-18 12:21:18 UTC
SVN commit 1037037 by aclemens:

Let the slider decide what size to take. I'll leave this code commented if
someone really thinks we need this.

BUG:210956

 M  +1 -1      statuszoombar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037037
Comment 4 Ignat Semenov 2009-10-18 16:19:56 UTC
Created attachment 37647 [details]
patch #2

It appears that setInvertedControls() in zoomSlider is unnecessary (using Qt4.6 snapshot). If it's not set, then Ctrl+Mouse Wheel Up zooms in the view and Mouse Wheel Up over zoom slider does the same. Zoom out works fine as well.