Bug 210910 - Please allow locking image zoom on the light table [patch]
Summary: Please allow locking image zoom on the light table [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: LightTable-Canvas (show other bugs)
Version: 1.0.0
Platform: Compiled Sources Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-17 20:53 UTC by kgw
Modified: 2022-02-01 09:08 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0


Attachments
Patch to keep a set zoom ratio when changing images... (452 bytes, patch)
2009-10-24 21:29 UTC, kgw
Details
Patch to keep a set zoom ratio when changing images. (3.86 KB, patch)
2009-10-25 14:16 UTC, kgw
Details
New version of the patch against rev 1054503 (4.42 KB, patch)
2009-11-26 08:18 UTC, Julien Narboux
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kgw 2009-10-17 20:53:09 UTC
Version:            (using KDE 4.3.2)
Installed from:    Compiled From Sources

When comparing images on the Light Table I usually do so at 100% view to work out which of a series to keep and which to delete. Upon deleting an image from the Light Table (moving to trash) the image zoom irritatingly resets to the scale that shows the whole image. Now I have to zoom in again to 100% to continue. For the moment this makes using the light table impossible!
Comment 1 kgw 2009-10-24 21:29:35 UTC
Created attachment 37802 [details]
Patch to keep a set zoom ratio when changing images...

Please would anyone with the knowledge how to do this properly in the context of digikam make this an option (setting either true for the previous behavior and false for the behavior I crave for)...
Comment 2 kgw 2009-10-25 14:16:57 UTC
Created attachment 37821 [details]
Patch to keep a set zoom ratio when changing images.

I have added a setting into the light table settings group.
Comment 3 Marcel Wiesweg 2009-11-04 12:17:22 UTC
Should we reset the zoom at all when loading a new image?
I mean, do we want an option for this or do we want to change it without offering an option?
If we want an option, what should be the default value?
Comment 4 caulier.gilles 2009-11-04 15:32:17 UTC
My viewpoint : an option with the current behavior as default settings.

We need more viewpoints here... Please 

Gilles
Comment 5 kgw 2009-11-04 17:56:06 UTC
I'm the one who would like this new behavior but the old one has been around for long enough as to have enough merit as not to abandon it. So even I second Gilles viewpoint - see my attached patch...
Comment 6 Julien Narboux 2009-11-21 18:54:48 UTC
I think the current situation make the light table quite impossible to use. When comparing picture they should always be at the same zoom ratio. I don't really understand the current behavior, even when you click on synchronize the zoom ratio is often reset to "zoom to fit". I think the zoom ratio should never be changed without user explicitly asking for it.

Julien
Comment 7 Julien Narboux 2009-11-26 08:18:17 UTC
Created attachment 38595 [details]
New version of the patch against rev 1054503
Comment 8 Julien Narboux 2009-11-26 08:20:30 UTC
Hi,

I tested the patch with current version it works well. I my opinion it should not be an option, or at least the new behavior should be the default. 

Julien
Comment 9 caulier.gilles 2009-11-26 08:22:47 UTC
Ok, let's go to take a try to this patch. apply it to svn, it's very simple to test...

Gilles
Comment 10 caulier.gilles 2010-01-22 18:34:50 UTC
Julien, 

Can you adjust this patch to not include settings panel change and use new defaut behaviors as well. I would to see it included in 1.1.0 release

Thanks in advance

Gilles Caulier
Comment 11 Julien Narboux 2010-01-22 19:09:38 UTC
Gilles,

The patch is already applied, i will remove the option.

Julien
Comment 12 Julien Narboux 2010-01-23 08:41:53 UTC
SVN commit 1078909 by jnarboux:

Undo compit 1054504, this removes the option for updating zoom ratio when new image is loaded in lighttable.
Make new behaviour be old default, we never update zoom ratio.

CCBUGS: 210910



 M  +1 -7      lighttable/lighttablepreview.cpp  
 M  +0 -1      lighttable/lighttablewindow_p.h  
 M  +0 -9      setup/setuplighttable.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078909