Bug 210518 - Add Option to disable the DSplitterButton
Summary: Add Option to disable the DSplitterButton
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 1.0.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-14 11:04 UTC by Andi Clemens
Modified: 2009-12-25 13:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Clemens 2009-10-14 11:04:54 UTC
Version:           1.0.0-beta6 (using 4.3.2 (KDE 4.3.2), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31-ARCH

For me this button is rather useless in digiKam, since we use a TabSideBar. It sometimes even happens that I close the sidebar now by accidentally clicking on this arrow.
In gwenview this button makes much more sense, since they remove the tabbar completely, but in digiKam we have not removed it (yet).

So my wish is to at least make this button configurable, or hide the sidebar completely (like in gwenview) when clicking this button.
Comment 1 Andi Clemens 2009-10-14 11:13:57 UTC
When going with the idea of hiding the sidebar completely, we should make sure the sidebar itself is not collapsible anymore via the tab icons.
Otherwise, again, the button makes not much sense.

If we want to keep the way the sidebar is collapsed right now (by clicking the tab icons), I would rather hide the DSplitterButton when the SideBar is expanded, and only display it when it has been collapsed.
Having two button so close together that to the same thing in an UI is just confusing otherwise.
Comment 2 caulier.gilles 2009-10-14 11:14:34 UTC
This button is just experimental. if we want to remove it, there is just one line to kill :

http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/sidebar.cpp?revision=1034786&view=markup

Look line 120...

Gilles
Comment 3 Andi Clemens 2009-10-14 11:18:48 UTC
The buttons could be really nice if we hide the sidebar completely. Maybe we should consider this behavior.
Otherwise it gets in the way, at least with my inexact clicking here :D
Comment 4 caulier.gilles 2009-10-14 14:54:00 UTC
SVN commit 1035165 by cgilles:

remove splitter bouton. code sound like not finalized.
BUGS: 210519
BUGS: 210518


 D             dsplitterbutton.cpp  
 D             dsplitterbutton.h  
 M  +0 -11     sidebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1035165