Bug 210020 - [PATCH] add Show Menubar to Settings menu to allow hiding menubar
Summary: [PATCH] add Show Menubar to Settings menu to allow hiding menubar
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.3-GIT
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 218260 219167 232080 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-09 21:59 UTC by Mike Smiley
Modified: 2011-04-18 09:18 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.4.1


Attachments
Adds ability to show/hide menu bar (2.74 KB, patch)
2010-09-20 23:01 UTC, Valentyn Pavliuchenko
Details
Adds ability to show/hide menu bar (2.72 KB, patch)
2010-09-20 23:33 UTC, Valentyn Pavliuchenko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Smiley 2009-10-09 21:59:25 UTC
Version:           2.2 (using KDE 4.3.1)
OS:                Linux
Installed from:    Unlisted Binary Package

Many other KDE programs allow hiding the menubar using either the Show Menubar toggle item in the Settings menu, or using the CTRL+M shortcut.

I think this feature would help amarok be consistent in KDE-land and also allow us who seldom use the menus to have a sleeker interface.
Comment 1 Valentyn Pavliuchenko 2009-11-26 18:45:13 UTC
Yeah, it's needed, especially for audio player. It is part of flexible UI, that Amarok is going to have last time (and must have - to feel comfortable).
Comment 2 Myriam Schweingruber 2009-12-11 13:50:19 UTC
*** Bug 218260 has been marked as a duplicate of this bug. ***
Comment 3 Myriam Schweingruber 2009-12-18 14:57:49 UTC
*** Bug 219167 has been marked as a duplicate of this bug. ***
Comment 4 Cyril Brosch 2010-01-10 18:06:10 UTC
Often it is objected to the "hide menu"-option, that users occasionally may type the shortcut and make the bar disappear without knowing how the get it back - it happened to me a few years ago, too.

A solution would be to add the toggle option, but to NOT define a shortcut for it.
Just write that in the release announcement, so that the ones who care can add crtl + m (or whatever) - which is no big effort -, and the ones who don't care don't have to do anything at all.
Comment 5 georgi 2010-01-10 19:32:58 UTC
The way it works in most applications, I think, is that the first time you use the shrotcut or the menu item, you get a popup message explaining that the menu will now be hidden, and that you can press the shortcut to get it back. The popup has a checkbox to not show it again, once you're used to the shortcut.

Your solutions has the problem that if I hide the menu without having set up a shortcut before that, I can't get it back at all.
Comment 6 Cyril Brosch 2010-01-10 19:36:26 UTC
Yes, it would be a problem, if there were a checkbox in the options or in the menu, I was just thinking about a shortcut as the only way for toggling the bar on/off, but maybe that's not a good idea.

The pop-up surely is superior.
Comment 7 Sven Krohlas 2010-03-25 09:13:19 UTC
*** Bug 232080 has been marked as a duplicate of this bug. ***
Comment 8 G360 2010-08-31 19:31:05 UTC
This would be a nice feature. As Georgi Chulkov said, many other KDE apps display the first time a message that explain all this (ctrl+m ...).

Alternatively, what do you think about removing the menubar, like many apps now do? e.g. Bangarang, Mini(tunes|tube), rekonq (and other web browsers)

The status bar is in my point of view almost useless, should also be made possible to hide or remove.
Comment 9 Valentyn Pavliuchenko 2010-09-20 23:01:11 UTC
Created attachment 51833 [details]
Adds ability to show/hide menu bar

Implemented in the same way as in Dolphin. "Show menubar" menu item (with Ctrl+M shortcut) is added to both main menu and popup menu of the main window.
Comment 10 Valentyn Pavliuchenko 2010-09-20 23:33:52 UTC
Created attachment 51835 [details]
Adds ability to show/hide menu bar

Implemented in the same way as in Dolphin. "Show menubar" menu item (with
Ctrl+M shortcut) is added to both main menu and popup menu of the main window.

Updated version, fixed initial checked status of the menu item.
Comment 11 Valentyn Pavliuchenko 2010-09-21 10:49:54 UTC
*** This bug has been confirmed by popular vote. ***
Comment 12 Valentyn Pavliuchenko 2010-09-25 11:47:17 UTC
Anybody there?
Comment 13 Myriam Schweingruber 2010-09-25 17:49:50 UTC
Valentin, now that reviewboard is working for Amarok, please submit your patch there: http://git.reviewboard.kde.org
Comment 14 Valentyn Pavliuchenko 2011-04-16 10:11:44 UTC
Please close this wish as done.
Comment 15 Myriam Schweingruber 2011-04-18 09:18:13 UTC
Closing.