Bug 209906 - Unportable test(1) construct in cleanup_digikamdb
Summary: Unportable test(1) construct in cleanup_digikamdb
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Runtime (show other bugs)
Version: 1.0.0
Platform: NetBSD pkgsrc NetBSD
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-08 20:55 UTC by Thomas Klausner
Modified: 2017-07-15 05:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0

Attachments
Patch fixing the problem. (558 bytes, patch)
2009-10-08 20:55 UTC, Thomas Klausner 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Klausner 2009-10-08 20:55:05 UTC 
Version:           1.0.0-beta5 (using KDE 4.3.1)
Compiler:          n/a n/a
OS:                NetBSD
Installed from:    NetBSD pkgsrc

The script utilities/scripts/cleanup_digikamdb uses the unportable bash "==" comparison operator for test(1). It is not supported by most other shells or even test(1) from GNU coreutils. Please use "=" instead.
Comment 1 Thomas Klausner 2009-10-08 20:55:40 UTC 
Created attachment 37454 [details]
Patch fixing the problem.
Comment 2 Thomas Klausner 2009-10-08 20:58:22 UTC 
Note: I know that it has "#!/bin/bash" at the beginning, but the script works fine otherwise and could be changed to just use /bin/sh instead.
Comment 3 Andi Clemens 2009-10-08 23:33:29 UTC 
SVN commit 1032924 by aclemens:

Use more portable comparison operator. Thanks to Thomas Klausner.

BUG:209906

 M  +3 -3      cleanup_digikamdb  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032924