Bug 209570 - ktimetracker lost nearly all actions with commit 1026315 in branch
Summary: ktimetracker lost nearly all actions with commit 1026315 in branch
Status: RESOLVED FIXED
Alias: None
Product: ktimetracker
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Thorsten Staerk
URL:
Keywords:
: 210441 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-05 22:03 UTC by Burkhard Lück
Modified: 2009-10-15 22:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2009-10-05 22:03:44 UTC
Version:            (using Devel)
Installed from:    Compiled sources

With http://websvn.kde.org/?view=revision&sortby=date&revision=1026315 KTimetracker lost nearly all actions.

svn up -r 1026314 kdepim/ktimetracker/ in branch and rebuilding solves this for me.
Comment 1 Thorsten Staerk 2009-10-05 22:09:53 UTC
thank you, very valuable report!
Comment 2 Thorsten Staerk 2009-10-05 22:13:28 UTC
Cannot reproduce, please give an example of a lost action.
Comment 3 Burkhard Lück 2009-10-05 22:33:40 UTC
svn info kdepim/ktimetracker
URL: https://lueck@svn.kde.org/home/kde/branches/KDE/4.3/kdepim/ktimetracker
Basis des Projektarchivs: https://lueck@svn.kde.org/home/kde
UUID des Projektarchivs: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Revision: 1031719

Menu:
File -> Import -> ""
File -> Export -> ""
Clock -> ""
Task -> ""
Settings + Help menu ok

Main Toolbar + Tasks selected, but no toolbar
Comment 4 Burkhard Lück 2009-10-07 14:10:54 UTC
With this patch I get all actions back:

$ svn diff kdepim/ktimetracker/
Index: kdepim/ktimetracker/mainwindow.cpp
==============================================
--- kdepim/ktimetracker/mainwindow.cpp  (Revision 1032238)
+++ kdepim/ktimetracker/mainwindow.cpp  (Arbeitskopie)
@@ -73,6 +73,7 @@
       ((TimetrackerWidget) (m_part->widget())).openFile(icsfile);
       connect(configureAction, SIGNAL(triggered(bool)),
         m_part->widget(), SLOT(showSettingsDialog()));
+      ((TimetrackerWidget *) (m_part->widget()))->setupActions( actionCollection() );
       m_part->openFile(icsfile);
       setupGUI();
     }
Comment 5 Albert Astals Cid 2009-10-07 22:41:58 UTC
Fails for me too
Comment 6 Burkhard Lück 2009-10-08 11:54:20 UTC
I just updated my Kubuntu 9.04 with the KDE 4.3.2 packages from
deb http://ppa.launchpad.net/kubuntu-ppa/backports/ubuntu jaunty main
deb http://ppa.launchpad.net/kubuntu-ppa/staging/ubuntu jaunty main

$ ktimetracker --version
Qt: 4.5.2
KDE: 4.3.2 (KDE 4.3.2)
KDE-Zeitplaner: 4.3.1

This version of ktimetracker is broken as described in my comment #3, therefore unusable.
Comment 7 Thorsten Staerk 2009-10-14 08:30:57 UTC
*** Bug 210441 has been marked as a duplicate of this bug. ***
Comment 8 Thorsten Staerk 2009-10-14 08:32:02 UTC
I accept this bug as reproducible because others can reproduce it, see bug 210441.
Comment 9 Thorsten Staerk 2009-10-14 23:46:27 UTC
SVN commit 1035393 by tstaerk:

Code cleanup

CCBUGS:209570


 M  +1 -1      mainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1035393
Comment 10 Thorsten Staerk 2009-10-14 23:55:35 UTC
(In reply to comment #4)
Burkhard,

> +      ((TimetrackerWidget *) (m_part->widget()))->setupActions(
> actionCollection() );

In my checkout, this line is already in. As well for trunk as for 4.3. Can you explain?
Comment 11 Thorsten Staerk 2009-10-15 00:07:14 UTC
all, as I tell from http://websvn.kde.org/?view=revision&revision=1032238 you are working in a branch that I do not know.
Comment 12 Albert Astals Cid 2009-10-15 19:09:15 UTC
(In reply to comment #10)

Then your 4.3 checkout is old, see how that line is not there in http://websvn.kde.org/branches/KDE/4.3/kdepim/ktimetracker/mainwindow.cpp?view=markup
Comment 13 Thorsten Staerk 2009-10-15 21:52:33 UTC
Indeed it was old and I wonder how I could overlook this. The relevant commit is http://websvn.kde.org/branches/KDE/4.3/kdepim/ktimetracker/mainwindow.cpp?r1=1026315&r2=1026314&pathrev=1026315
Comment 14 Thorsten Staerk 2009-10-15 21:53:26 UTC
This commit was done to resolve bug 194865. Thanks you two for the correction.
Comment 15 Thorsten Staerk 2009-10-15 22:08:11 UTC
SVN commit 1035759 by tstaerk:

Show menues again in ktimetracker.
BUGS:209570


 M  +1 -0      mainwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1035759