Bug 208821 - Opening links in new window puts focus on location bar instead of the page
Summary: Opening links in new window puts focus on location bar instead of the page
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-28 22:48 UTC by Christoph Feck
Modified: 2010-05-12 15:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2009-09-28 22:48:29 UTC
Version:            (using Devel)
Installed from:    Compiled sources

I set middle click to open links in new window. When I click on a link this way, the focus for the newly opened window is on the location bar instead of the page. This means pressing pageup/pagedown does not work, I have to click into the page first.

There is no reason to activate the location bar in this case, because I likely want to view that page, not enter a different address.

This is a regression from KDE3.
Comment 1 David Faure 2010-05-12 01:20:18 UTC
SVN commit 1125692 by dfaure:

Re-do the usability fix #84867 in a way that doesn't introduce #208821:
focus the location bar when actively (as a user) switching to an empty tab,
but not when loading a tab which will soon get content.
Fixed for: 4.5
BUG: 208821


 M  +6 -1      konqframe.cpp  
 M  +2 -0      konqmain.cpp  
 M  +0 -4      konqmainwindow.cpp  
 M  +20 -4     tests/konqviewmgrtest.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1125692
Comment 2 David Faure 2010-05-12 02:20:44 UTC
SVN commit 1125699 by dfaure:

And now fix 208821 for real, there was an older piece of code attempting to do the same thing already,
but also ignoring the cases where the url is opened after the window is created.
CCBUG: 208821


 M  +0 -3      konqviewmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1125699
Comment 3 David Faure 2010-05-12 15:49:09 UTC
SVN commit 1125850 by dfaure:

And fix #208821 again, this time without breaking the feature of "a new empty window should get the focus in the location bar".
CCBUG: 208821.


 M  +1 -1      konqmisc.h  
 M  +5 -0      konqviewmanager.cpp  
 M  +13 -0     tests/konqviewmgrtest.cpp  
 M  +1 -0      tests/konqviewmgrtest.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1125850