Bug 208373 - i18n bug trunk + branch: catalog not loaded, wrong use of I18N_NOOP
Summary: i18n bug trunk + branch: catalog not loaded, wrong use of I18N_NOOP
Status: RESOLVED FIXED
Alias: None
Product: kget
Classification: Applications
Component: plasma widget (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-24 12:02 UTC by Burkhard Lück
Modified: 2009-09-24 18:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
fix to use proper catalog + i18n call (2.61 KB, patch)
2009-09-24 12:04 UTC, Burkhard Lück
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2009-09-24 12:02:31 UTC
Version:            (using Devel)
Installed from:    Compiled sources

the kget plasmoids and datengine are buggy i18n wise, since 2 years. That's 
incredible.

kgetengine.cpp has these lines:

setData(I18N_NOOP(name), I18N_NOOP("error"), false);
setData(I18N_NOOP(name), I18N_NOOP("transfers"),
                                                 kget_interface.transfers().value());
setData(I18N_NOOP(name), I18N_NOOP("error"), true);
setData(I18N_NOOP(name), I18N_NOOP("errorMessage"), 
                                        I18N_NOOP("Is KGet up and running?"));
setData(I18N_NOOP("KGet"), I18N_NOOP("error"), false);
setData(I18N_NOOP("KGet"), I18N_NOOP("transfers"), transfers);

api says setData (source, key, value)

The I18N_NOOP do nothing but mark the messages only for extraction, this does 
not return a translation.

And to be honest, do you realy want a translated source and key in these 
calls? I'm sure that will not work.

the only place where you need an i18n here is the string  "Is KGet up 
and running?", which I see untranslated in the GUI cause of the wrong 
I18N_NOOP, which has to be changed to i18n().

the patch solves this issue, any objection to commit?
Comment 1 Burkhard Lück 2009-09-24 12:04:24 UTC
Created attachment 37148 [details]
fix to use proper catalog + i18n call
Comment 2 Lukas Appelhans 2009-09-24 15:25:48 UTC
Thanks for notifying... please commit! :)

Lukas
Comment 3 Burkhard Lück 2009-09-24 18:35:55 UTC
SVN commit 1027741 by lueck:

load translation catalog, fix wrong use of I18N_NOOP in trunk
CCBUG:208373

 M  +1 -0      applet/barapplet/kgetbarapplet.cpp  
 M  +2 -0      applet/panelbar/kgetpanelbar.cpp  
 M  +1 -0      applet/piechart/kgetpiechart.cpp  
 M  +4 -5      engine/kgetengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1027741
Comment 4 Burkhard Lück 2009-09-24 18:36:47 UTC
SVN commit 1027742 by lueck:

backport from trunk r1027741: load translation catalog, fix wrong use of I18N_NOOP
BUG:208373

 M  +1 -0      applet/barapplet/kgetbarapplet.cpp  
 M  +2 -0      applet/panelbar/kgetpanelbar.cpp  
 M  +1 -0      applet/piechart/kgetpiechart.cpp  
 M  +5 -7      engine/kgetengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1027742