Bug 207239 - When pressing Enter thumbnails should be enlarged, also after changing from Tags to Collection or similar
Summary: When pressing Enter thumbnails should be enlarged, also after changing from T...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Preview-Image (show other bugs)
Version: 1.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-13 11:45 UTC by Simon
Modified: 2012-06-27 11:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2009-09-13 11:45:39 UTC 
Version:           1.0.0-beta5 (rev.: 1022091) (using 4.3.1 (KDE 4.3.1), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.31-rc8-sidux-686

Same as #202779, but when changing the view (left sidebar), e.g. from Albums to Tags. The first thumbnail is selected, but pressing enter does not enlarge it.
Comment 1 Andi Clemens 2009-09-13 11:49:14 UTC 
Hm I thought I fixed that... let me check.
Comment 2 Andi Clemens 2009-09-13 11:50:26 UTC 
Hey, it is broken again... who was it :) 
I'll need to do a little bit indeep checking... I'll assign it to me.

Andi
Comment 3 Simon 2009-09-13 11:54:54 UTC 
Okay, thank you :)

Simon
Comment 4 Andi Clemens 2009-09-13 13:07:22 UTC 
"Git bisect" tells me that adding the "dockable thumbbar" patch causes this regression.
I will try to fix it and CC Pieter, too.
Comment 5 Andi Clemens 2009-09-13 15:01:30 UTC 
SVN commit 1022894 by aclemens:

Fix regression.

Pieter,
why have you changed this behavior? Maybe I don't see the point right
now.
If you think that those lines actually belong there, please revert this
patch and modify it so that the old behavior is still working.

Otherwise we can close this bug later on.

CCBUG:207239

 M  +4 -5      albumwidgetstack.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022894
Comment 6 Pieter Edelman 2009-09-13 18:02:34 UTC 
Andi, I probably used an outdated snapshot to write those changes and didn't see this particular change when updating my changes to the SVN line (still learning to use SVN to it's full potential :). So this bug should be closed. Sorry for the inconvenience.
Comment 7 Andi Clemens 2009-09-13 18:07:36 UTC 
Hey, no problem :D