Bug 207058 - Renaming in BQM should be a tool
Summary: Renaming in BQM should be a tool
Status: RESOLVED NOT A BUG
Alias: None
Product: digikam
Classification: Applications
Component: AdvancedRename-BatchQueueManager (show other bugs)
Version: 1.0.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 11:14 UTC by Andi Clemens
Modified: 2022-01-14 09:56 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Clemens 2009-09-11 11:14:41 UTC
Version:           1.0.0-beta5 (using 4.3.1 (KDE 4.3.1), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.30-ARCH

Right now renaming files with BQM is not possible. If you want to rename them, you need to

a) assign a target folder
b) assign a tool

to make BQM work at all. But this is not renaming, it is a copy action.
Since I provided another patch for file renaming in AlbumUI (bug 207053), the purpose of a RenameTool for BQM should be to have different renaming schemes for the queues.
It COULD be possible to only rename files with the tool, but actually this is what bug 207053 is for.

A "rename only" solution would be very hackish in my opinion, because we need to determine how many tools are assigned and which tools they are.
To make "rename only" work, we would look for the assigned tools, determine that only RenameTool has been assigned, disable the target location (but how, the user still might want to copy the files in there, or he might not ;-), hard to tell without further options).

So as you can see, I'm not really sure what to do here.
Keep the RenameTool (already in trunk, but deactivated), remove it again, if not, how to actually use it?

As I said before, renaming should actually be done in AlbumUI (bug 207053), the rest is a bonus for BQM, but not the main renaming method.

What do you think?
And what solutions could you imagine here?

Andi
Comment 1 Andi Clemens 2009-09-11 16:28:10 UTC
I'm beginning to think that a rename tool actually isn't needed :D
It makes renaming so much more complicated.

Also I noticed that the QueueSettings already have the ability to set different renaming rules for the queues, so the only good reason to have this tool is gone now :)

As mentioned before, bug 207053 should be used for general renaming.
The file renaming options used in BQM at the moment are enough if we use the solution from bug 207053.

I will mark this wish as INVALID now, because I don't see any good reason for the tool anymore.

If you agree, I will also revert the commit #1020656 that introduced the tool and made some changes to the BQM containers.

To sum this up:
1. If we use the idea mentioned in bug 207053, the RenameTool becomes useless
2. Queues ARE already aware of different renaming schemes, so the tool would become useless
3. Instead of a rename tool we should think about a way to MOVE files around, as wished by some users. At the moment BQM only copies files.

Andi
Comment 2 caulier.gilles 2009-09-11 16:44:04 UTC
>If you agree, I will also revert the commit #1020656 that introduced the tool
>and made some changes to the BQM containers.

ok

Gilles