Bug 206747 - dngconverter temp files not properly renamed
Summary: dngconverter temp files not properly renamed
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-DngConverter (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 15:31 UTC by Gustavo Claramunt
Modified: 2018-03-23 11:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.8.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Claramunt 2009-09-08 15:31:15 UTC
Version:            (using KDE 4.3.1)
OS:                Linux
Installed from:    Ubuntu Packages

During the resolution of bug #204437 i noticed one day dngconverter stopped renaming properly ouput files. Firstly i supposed it being a failure with my precompiled packages mixing with manual compiled ones, but today i've installed a fresh kubuntu karmic alpha-5 and the problem is the same.

I think is related to migration from kde 4.3.0 to kde 4.3.1, but i can't assure...

The behaviour is as flollows:
1.-Open raw file with dngconverter.
2.-Press convert.
3.-Wait conversion finish.
4.-Result 2 files:
4a-1 file correctly named but full of "null" data.
4b-1 hidden file named ".kipi-dngconverter-tmp-XXXXXXXXXXXXXX" containing the "true" dng.

The debug trace:
goose@goose-dev:~$ dngconverter montar/svn2/original.orf                        
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Loading RAW data from  "original.orf"                               
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Raw data loaded:                                                    
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Data Size:      20832000  bytes                                            
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Date:           "2009-07-26T20:16:46"                                      
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Make:           "OLYMPUS"                                                  
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Model:          "E-420"                                                    
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Size:           3720 x 2800                                                
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Orientation:    0                                                          
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Top margin:     0                                                          
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Left margin:    0                                                          
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Filter:         "RGGBRGGBRGGBRGGB"                                         
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Colors:         3                                                          
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- Black:          68                                                         
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- White:          4055                                                       
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: --- CAM->XYZ:   
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert:                     "0.8746  -0.2425  -0.1095"                                 
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert:                     "-0.7594  1.5612  0.2073"
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert:                     "-0.1780  0.2309  0.7416"
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert:                     "0.0000  0.0000  0.0000"
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Formating RAW data to memory
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG memory allocation and initialization
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG IFD structure creation
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG Negative structure creation
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Updating metadata to DNG Negative
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Backup Makernote ( 651928  bytes)
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Backup Original RAW file ( 9506248  bytes)
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Zipped RAW file size  9385065  bytes
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Build DNG Negative
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG preview image creation
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG thumbnail creation
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Creating DNG file  ".kipi-dngconverter-tmp-1252415746"
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: Backup meta-data using Exiv2
kipi-plugins(2940)/KIPI (general) DNGIface::DNGWriter::convert: DNGWriter: DNG conversion complete...

Tested with latest karmic packages AND tested with latest kipi-plugins svn (see bug #204437).

Thanks,
Goose.
Comment 1 caulier.gilles 2009-09-08 15:47:09 UTC
Not reproducible here. KDE 4.2.2, Mandriva 2009.1, kipi-plugins from trunk

Gilles Caulier
Comment 2 Gustavo Claramunt 2009-09-08 15:52:21 UTC
Yeah, i think it broke whith kde 4.3.1.

If what do you get in debug line "Creating DNG file  ".kipi-dngconverter-tmp-1252415746"? The correct (real) name or a similar one?
Comment 3 Andi Clemens 2009-09-08 15:55:09 UTC
I have KDE 4.3.1 installed, I'll test this as soon as I'm home.

Andi Clemens
Comment 4 caulier.gilles 2009-09-08 15:59:23 UTC
code use ::stat() and ::rename() functions from glibc. Nothing special here... Sound like a problem from your core system....

Gilles Caulier
Comment 5 Andi Clemens 2009-09-09 10:41:17 UTC
I tested this now with KDE 4.3.1 and glibc 2.10.1.
Working fine here so I guess, as Gilles also mentioned, there is a problem with you system.

Other information (not all relevant to KIPI):

digiKam version 1.0.0-beta5
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: No
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibExiv2: 0.18
LibJPEG: 70
LibJasper: 1.900.1
LibKDE: 4.3.1 (KDE 4.3.1)
LibKExiv2: 1.0.0
LibKdcraw: 1.0.0
LibLCMS: 118
LibPGF: 6.09.24
LibPNG: 1.2.39
LibQt: 4.5.2
LibRaw: 0.8.2
LibTIFF: LIBTIFF, Version 3.9.1 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.8.1
Parallelized demosaicing: Yes
LibGphoto2: 2.4.6
LibKipi: 1.0.0
Comment 6 Gustavo Claramunt 2009-09-09 18:06:01 UTC
Ok, maybe ubuntu's fault...
But i've tested today with opensuse with the same results.
NOTE: maybe another package-mix is the guilty, i've never used opensuse and mixing repositories often break things!
But it's extrange the same error here...

I'll test removing every digikam related package from this opensuse and manual compile them all, but it's difficult with so many dependancies, so give me some time...

digiKam version 0.10.0
Exiv2 can write to Jp2: Sí
Exiv2 can write to Jpeg: Sí
Exiv2 can write to Png: Sí
Exiv2 can write to Tiff: Sí
Exiv2 support XMP metadata: Sí
LibCImg: 130
LibExiv2: 0.18.2
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.3.1 (KDE 4.3.1) "release 161"
LibKExiv2: 0.6.0
LibKdcraw: 0.5.0
LibLCMS: 117
LibPNG: 1.2.31
LibQt: 4.5.2
LibRaw: 0.7.2
LibTIFF: LIBTIFF, Version 3.8.2 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.8.1
LibGphoto2: 2.4.3
LibKipi: 0.4.0
Comment 7 Gustavo Claramunt 2009-09-10 12:42:33 UTC
Ok, finished testing again. Built (under openSUSE) kdegraphics and digikam/kipi-plugins with latest svn as described in digikam.org website. Same failure, temporal file not renamed resulting 2 files, one correctly named full of "NULL", and other hidden file named .kipi-dngconverter-tmp-xxxxxxx with the actual image data.

Pasted digikam help components window:
digiKam version 1.0.0-beta5 (rev.: 1021831)
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: No
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibExiv2: 0.18.2
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.3.1 (KDE 4.3.1) "release 161"
LibKExiv2: 1.0.0
LibKdcraw: 1.0.0
LibLCMS: 117
LibPGF: 6.09.24
LibPNG: 1.2.31
LibQt: 4.5.2
LibRaw: 0.8.2
LibTIFF: LIBTIFF, Version 3.8.2 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Parallelized demosaicing: Yes
LibGphoto2: 2.4.3
LibKipi: 1.0.0


Is there anything else i can test?
Comment 8 caulier.gilles 2009-09-10 13:02:33 UTC
As, file operation is based on GLic api, take a look if issue described below is not the problem :

https://bugs.kde.org/show_bug.cgi?id=196207

Gilles Caulier
Comment 9 Gustavo Claramunt 2009-09-10 13:09:59 UTC
OK people, i must apologize SO much!
It all turned out being an error with shared folders within virtualbox... i've tested copying the file "inside" de virtualized hard drive instead accessing directly over the mounted folder and it works properly.

One simple question before closing this bug:
Can anyone test (on a real system, not a virtualized one) dngconverter against files over remote collections (samba, network)/removable media?
Comment 10 caulier.gilles 2009-10-01 12:07:32 UTC
Andi,

Do you have a shared collection over the network to test as Gustavo said in #9

Gilles
Comment 11 caulier.gilles 2009-10-26 13:15:40 UTC
Gustavo,

Tested with an USB key mounted locally. All work fine if i convert some RAW files from this media...

Gilles Caulier
Comment 12 Gustavo Claramunt 2009-10-26 13:18:53 UTC
Cool then, one bug killed ;)
I'll keep my eyes open.
Thanks.