Bug 206475 - [PATCH] Screensaver enables after leaving full screen mode
Summary: [PATCH] Screensaver enables after leaving full screen mode
Status: RESOLVED DUPLICATE of bug 186908
Alias: None
Product: kscreensaver
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-06 12:23 UTC by Bram Schoenmakers
Modified: 2010-04-08 01:17 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to only enable screensaver when configuration says so (560 bytes, patch)
2009-12-27 21:32 UTC, Bram Schoenmakers
Details
Patch to only enable screensaver when configuration says so (476 bytes, patch)
2010-03-10 23:31 UTC, Bram Schoenmakers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bram Schoenmakers 2009-09-06 12:23:42 UTC
Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Unlisted Binary Package

After leaving the full screen mode in Gwenview, the screensaver kicks in after 1 mor 2 minutes of inactivity. It should be noted that I don't have a screensaver set at all.

Maybe this is related to bug 185916 and commit 979204.

I see this in KDE 4.3.1, but I also observed this in KDE 4.3.0 and 4.2.4. I don't exactly remember from which version I started to observe this. Using KDEmod packages (Arch Linux).
Comment 1 Aurelien Gateau 2009-09-06 14:56:52 UTC
This is most likely related to the KNotificationRestrictions class.
Comment 2 Bram Schoenmakers 2009-12-27 21:32:59 UTC
Created attachment 39393 [details]
Patch to only enable screensaver when configuration says so

This patch fixes the bug, it's a patch against the KDE 4.3 branch, but the same trick is also applicable to trunk.

Can I commit this?
Comment 3 Bram Schoenmakers 2010-03-10 23:31:53 UTC
Created attachment 41523 [details]
Patch to only enable screensaver when configuration says so

Previous uploaded patch was messed up due to git's colored output. A new attempt.
Comment 4 Aurelien Gateau 2010-04-05 10:07:06 UTC
Patch looks simple enough, but I suggest you post it on http://reviewboard.kde.org so that KRunner devs can review it.
Comment 5 Bram Schoenmakers 2010-04-07 13:47:54 UTC
SVN commit 1112121 by bram:

Do not enable screensaver when it's switched off in the settings.

BUG:206475

 M  +1 -1      saverengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1112121
Comment 6 Anne-Marie Mahfouf 2010-04-07 14:40:56 UTC
Shouldn't that be backported to 4.4 branch?
Comment 7 Bram Schoenmakers 2010-04-07 23:51:19 UTC
SVN commit 1112343 by bram:

Backport r1112121: do not enable screensaver when it's switched off in the settings.

CCBUG:206475

 M  +1 -1      saverengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1112343
Comment 8 Oswald Buddenhagen 2010-04-08 01:17:41 UTC

*** This bug has been marked as a duplicate of bug 186908 ***