Bug 206357 - Tools / Resize - two dimensions are not proportionately resized
Summary: Tools / Resize - two dimensions are not proportionately resized
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Bqm-Resize (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-05 12:54 UTC by Milan Knížek
Modified: 2018-03-23 11:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.7.0

Attachments
Patch for 2 dim proportional resize (4.02 KB, patch)
2009-09-23 18:42 UTC, Johannes Wienke 		Details
Patch for 2 dim proportional resize (3.84 KB, patch)
2009-09-23 18:59 UTC, Johannes Wienke 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Knížek 2009-09-05 12:54:35 UTC 
Version:           digikam-1.0.0. beta4 kipi-plugins-0.6.0 (using KDE 4.2.4)
OS:                Linux
Installed from:    Compiled From Sources

In digiKam 1.0.0 beta4 with kipi-plugins 0.6.0 the image resizing (in Tools / Resize) with type "Proportional (2 dim)" does not keep the x:y ratio - images are distorted to fit the destination size in pixels.
Comment 1 Aurelien Gateau 2009-09-06 15:03:39 UTC 
I can reproduce. Thanks for reporting this.
Comment 2 Johannes Wienke 2009-09-23 16:34:20 UTC 
I could patch this, but what exactly is the desired behaviour for the border setting?
Comment 3 Johannes Wienke 2009-09-23 18:39:04 UTC 
With a first guess how border should be interpreted... Here is a patch.
Comment 4 Johannes Wienke 2009-09-23 18:42:30 UTC 
Created attachment 37130 [details]
Patch for 2 dim proportional resize
Comment 5 Andi Clemens 2009-09-23 18:47:01 UTC 
I would use qMin and qMax for portability...
Comment 6 Johannes Wienke 2009-09-23 18:59:01 UTC 
Created attachment 37131 [details]
Patch for 2 dim proportional resize

Now with qMin and qMax
Comment 7 caulier.gilles 2009-09-24 12:26:39 UTC 
SVN commit 1027561 by cgilles:

fix proportionnal resizing rule.with 2 dims
BUGS: 206357
BUGS: 135411


 M  +108 -59   resizeimagesdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1027561