Bug 206345 - files without extensions not recognized
Summary: files without extensions not recognized
Status: RESOLVED NOT A BUG
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.3-GIT
Platform: openSUSE Linux
: NOR normal
Target Milestone: 2.3.1
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-05 12:01 UTC by m0nk
Modified: 2009-10-03 21:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
See files without extensions in Play Media/related dialogs. (707 bytes, patch)
2009-10-03 18:39 UTC, Tycho Andersen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description m0nk 2009-09-05 12:01:23 UTC
Version:            (using KDE 4.3.0)
Compiler:          gcc 
OS:                Linux
Installed from:    SuSE RPMs

Amarok doesn't recognize (audio-)files without extension. They don't show up in the 'open media' dialog, until you type in the first letters (filter?). When loaded, amarok doesn't read in the meta information (taglib?), but plays the track.
Comment 1 Myriam Schweingruber 2009-09-05 13:27:16 UTC
I guess you are using 2.2-git, right?
Comment 2 m0nk 2009-09-05 16:40:23 UTC
Yes, but it doesn't depend on the version. It didn't work in 2.0.1, too. And I'm on SVN/Git since then.
Comment 3 Myriam Schweingruber 2009-09-05 16:53:22 UTC
(In reply to comment #2)
> Yes, but it doesn't depend on the version. It didn't work in 2.0.1, too. And
> I'm on SVN/Git since then.

Well, we always set the version to the most recent where that occurs, hence 2.2-git. BTW, this never worked in Amarok 2.x anyway, strange that nobody reported it earlier, seems that people mostly have extensions in their filenames.
Comment 4 Tycho Andersen 2009-10-03 18:39:08 UTC
Created attachment 37338 [details]
See files without extensions in Play Media/related dialogs.

Not sure why exactly this patch fixes the bug (it seems to me that the other way should have worked too), but it does. Maybe someone who knows more about KFileDialog can enlighten me.
Comment 5 Mark Kretschmann 2009-10-03 18:56:00 UTC
Erm, I'd like to emphasize that Amarok does not support files without extensions, as TagLib uses the extension.

Detecting the right file type without extension requires opening and reading the file itself, which takes considerably longer. So I doubt it will ever be supported, or at least not in the near future.
Comment 6 Jeff Mitchell 2009-10-03 19:06:52 UTC
Is there a use-case for files without extensions? Why is it important to support them?
Comment 7 Tycho Andersen 2009-10-03 19:44:12 UTC
Why to support them: I have no idea. All my music files have extensions. This just looked like something I would know how to fix, so I did.

I suppose maybe you could use Amarok to test whether or not a file was a playable media file, but it seems like the 'file' command is more suited for that purpose.
Comment 8 Jeff Mitchell 2009-10-03 21:42:01 UTC
But this isn't a fix, you're just changing the filter to show all files -- which means *all* files, not just media files without an extension.