Bug 206344 - [PATCH] avatars do not work on windows due to usage of path() instead of toLocalFile()
Summary: [PATCH] avatars do not work on windows due to usage of path() instead of toLo...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: libkopete (show other bugs)
Version: unspecified
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Matt Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-05 11:53 UTC by jens
Modified: 2010-01-08 19:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
my (quick and dirty) patch (4.52 KB, patch)
2009-09-05 11:57 UTC, jens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jens 2009-09-05 11:53:43 UTC
Version:           0.70.90 (using Devel)
Compiler:          msvc2008 x64
OS:                MS Windows
Installed from:    Compiled sources

Pictures of avatars aren't visible and I cant 
set an avatar to my user account. The reason is that kopete fails to 
write down the avatar as png in my user profile. I can see the complete 
folder structure under:
c:\users\[myuser]\appdata\roaming\.kde\share\apps\kopete\avatars\

but when writing the image to the disk the path looks like:
D:\c:\users\[myuser]\appdata\roaming\.kde\share\apps\kopete\avatars\User\50ebb0ef48852b1f0fa7f48ff7750ff3.png 
(thanks to Process Monitor)

According to Ralf Habacker from the windows team this is an path() vs. toLocalFile() issue. I tried to replace all occurrences of path() with toLocalFile() in kopeteavatarmanager.cpp and the issue is (at least for me) resolved.
Comment 1 jens 2009-09-05 11:57:24 UTC
Created attachment 36707 [details]
my (quick and dirty) patch
Comment 2 jens 2009-09-05 11:58:09 UTC
see here for the discussion on kde-windows:
http://mail.kde.org/pipermail/kde-windows/2009-September/004108.html
Comment 3 Matt Rogers 2009-09-06 21:55:43 UTC
Awesome. Thanks for the patch. When I get it committed, I'll close the bug.
Comment 4 Christian Ehrlicher 2010-01-08 19:26:22 UTC
fixed with one of my KUrl::path() -> KUrl::toLocalFile() changes