Bug 205880 - Bugs in Aggregation GroupByDateRange
Summary: Bugs in Aggregation GroupByDateRange
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-01 11:16 UTC by A. Pfaller
Modified: 2009-09-06 20:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix for the previously described problems (1.81 KB, patch)
2009-09-01 11:18 UTC, A. Pfaller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description A. Pfaller 2009-09-01 11:16:06 UTC
Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Compiled From Sources

1) Using aggregation by date range in the messagelist showed a couple of messages from the beginning of August 2009 under an "Unknown" heading when displayed at the end of August because the code handles only up to "4 weeks ago" (i.e. 28 days) correctly. Patch attached.

2) In my opinion the aggregation code is somewhat to aggressive in grouping messages in large aggregations. E.g. At the beginning of the week I am usually very interested in the mails I have not yet handled completely which arrived at the end of the previous week. But e.g. today (Tue, 2009-09-01) these are lumped in an big "August" aggregation. The attached patch always groups the last seven days in individual aggregations (by day).
Comment 1 A. Pfaller 2009-09-01 11:18:49 UTC
Created attachment 36609 [details]
Fix for the previously described problems
Comment 2 Thomas McGuire 2009-09-06 20:42:12 UTC
Thanks for the patch, I committed it in revision 1020611, see http://websvn.kde.org/?view=rev&revision=1020611.

The patch will be part of KDE 4.4 (can't be in KDE 4.3.2 since it has a string change)

Please use reviewboard for your next patch, see http://techbase.kde.org/Contribute/Send_Patches#Reviewboard. Otherwise it is easy for patches to get lost.