Bug 204846 - German translation: system monitor "disk space" no pluralization
Summary: German translation: system monitor "disk space" no pluralization
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-systemmonitor (show other bugs)
Version: unspecified
Platform: Gentoo Packages Unspecified
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-23 11:26 UTC by Christian Janoff
Modified: 2009-09-01 22:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Janoff 2009-08-23 11:26:07 UTC
Version:            (using KDE 4.3.0)
Installed from:    Gentoo Packages

Zur Reproduktion:

1. Widget "Systemmonitor - Festplatte" auf den Desktop legen.
2. Aus dem Widget-Kontextmenü "Einstellungen für "Systemmonitor - Festplatte" auswählen.
3. Den Wert "Aktualisierungsintervall" auf 1 oder 2 verringern bzw. erhöhen.

Wenn vorher mindestens der Wert 2 gespeichert war, steht nach dem Setzen auf 1 der Text "1 Minuten" da (falsch).

Wenn vorher 1 gespeichert war, steht nach dem Setzen auf mindestens 2 der Text "2 Minute" da (ebenfalls falsch).

Der Text wird offenbar nicht dynamisch während der Auswahl der Minutenanzahl geändert.
Comment 1 Albert Astals Cid 2009-08-23 22:26:51 UTC
No idea if this is a problem with the code or with the translation but i don't understand german at all so reassigning to the "de" team so they can chime in an help
Comment 2 Christian Janoff 2009-08-23 23:10:55 UTC
This seems to be a problem with the code.

Pluralization works but it's not done immediately while changing the time value.

When I close the dialog and open it again, the correct plural or singular form (depending on the previously stored value) appears.
Comment 3 Albert Astals Cid 2009-08-24 00:37:11 UTC
Code bug yes, Andrius tried to fix it but failed, Andrius can you fix it please?
the connect line
 connect(ui.intervalSpinBox, SIGNAL(valueChanged()), this, SLOT(ui.intervalSpinBox(int)));
in hdd.cpp is totally broken
Comment 4 Burkhard Lück 2009-08-31 16:51:11 UTC
This one line change fixes this for me:

kde43@rebutia:~/svn$ svn diff  kdebase/workspace/plasma/applets/system-monitor/hdd.cpp
Index: kdebase/workspace/plasma/applets/system-monitor/hdd.cpp
===================================================================
--- kdebase/workspace/plasma/applets/system-monitor/hdd.cpp     (Revision 1017767)
+++ kdebase/workspace/plasma/applets/system-monitor/hdd.cpp     (Arbeitskopie)
@@ -84,7 +84,7 @@
     updateSpinBoxSuffix(interval() / 60 / 1000);

     parent->addPage(widget, i18n("Partitions"), "drive-harddisk");
-    connect(ui.intervalSpinBox, SIGNAL(valueChanged()), this, SLOT(ui.intervalSpinBox(int)));
+    connect(ui.intervalSpinBox, SIGNAL(valueChanged(int)), this, SLOT(updateSpinBoxSuffix(int)));
     connect(parent, SIGNAL(applyClicked()), this, SLOT(configAccepted()));
     connect(parent, SIGNAL(okClicked()), this, SLOT(configAccepted()));
Comment 5 Andrius Štikonas 2009-08-31 17:21:59 UTC
Does this bug appear only in 4.3 branch? I think that I reimplemented this with ki18np() and KIntSpinBox in KDE 4.4 which is the right way to go since ki18np() is available.
Comment 6 Burkhard Lück 2009-08-31 17:29:48 UTC
(In reply to comment #5)
> Does this bug appear only in 4.3 branch? 

Yes, only in 4.3 branch, not in trunk.
Comment 7 Andrius Štikonas 2009-08-31 18:09:04 UTC
SVN commit 1017822 by stikonas:

Fix pluralization support
BUG: 204846


 M  +8 -1      hdd-config.ui  
 M  +1 -7      hdd.cpp  
 M  +0 -1      hdd.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017822
Comment 8 Andrius Štikonas 2009-08-31 18:11:49 UTC
Please review and test: http://websvn.kde.org/?view=rev&revision=1017822
Comment 9 Burkhard Lück 2009-09-01 08:01:07 UTC
(In reply to comment #8)
> Please review and test: http://websvn.kde.org/?view=rev&revision=1017822

Your commit breaks the build of kdebase here:
Scanning dependencies of target plasma_applet_sm_hdd
[ 78%] Building CXX object workspace/plasma/applets/system-monitor/CMakeFiles/plasma_applet_sm_hdd.dir/plasma_applet_sm_hdd_automoc.o
[ 78%] Building CXX object workspace/plasma/applets/system-monitor/CMakeFiles/plasma_applet_sm_hdd.dir/hdd.o
In file included from /home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.cpp:19:
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.h:53: Fehler: »Ui« wurde nicht deklariert
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.h:53: Fehler: ISO-C++ verbietet Deklaration von »config« ohne Typ
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.h:53: Fehler: expected »;« before »ui«
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.cpp: In member function »virtual void Hdd::createConfigurationInterface(KConfigDialog*)«:
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.cpp:58: Fehler: »ui« wurde in diesem Gültigkeitsbereich nicht definiert
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.cpp: In member function »void Hdd::configAccepted()«:
/home/kde42/svn/kdebase/workspace/plasma/applets/system-monitor/hdd.cpp:110: Fehler: »ui« wurde in diesem Gültigkeitsbereich nicht definiert
make[2]: *** [workspace/plasma/applets/system-monitor/CMakeFiles/plasma_applet_sm_hdd.dir/hdd.o] Fehler 1
make[2]: Das Target »workspace/plasma/applets/system-monitor/CMakeFiles/plasma_applet_sm_hdd.dir/build« wurde wegen Fehlern nicht aktualisiert.
make[1]: *** [workspace/plasma/applets/system-monitor/CMakeFiles/plasma_applet_sm_hdd.dir/all] Fehler 2
Comment 10 Andrius Štikonas 2009-09-01 20:10:48 UTC
SVN commit 1018462 by stikonas:

Fix syntax error in UI file.
BUG: 204846


 M  +7 -7      hdd-config.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1018462
Comment 11 Burkhard Lück 2009-09-01 22:28:37 UTC
Builds now and the bug is fixed, thanks.