Bug 204322 - Copy with rename file name is broken if url has protocol
Summary: Copy with rename file name is broken if url has protocol
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-18 20:49 UTC by Giuseppe Della Bianca
Modified: 2009-08-19 12:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Giuseppe Della Bianca 2009-08-18 20:49:21 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Hi.

In

file
jobuidelegate.cpp

function
KIO::RenameDialog_Result KIO::JobUiDelegate::askFileRename(KJob * job,
                                                           const QString & caption,
                                                           const QString& src,
                                                           const QString & dest,
                                                           KIO::RenameDialog_Mode mode,
                                                           QString& newDest,
                                                           KIO::filesize_t sizeSrc,
                                                           KIO::filesize_t sizeDest,
                                                           time_t ctimeSrc,
                                                           time_t ctimeDest,
                                                           time_t mtimeSrc,
                                                           time_t mtimeDest)

section
    KIO::RenameDialog_Result res = static_cast<RenameDialog_Result>(dlg.exec());
    newDest = dlg.newDestUrl().toLocalFile();

The newDest = dlg.newDestUrl().toLocalFile(); not work with url with protocol, I think is good dlg.newDestUrl().path();
Comment 1 David Faure 2009-08-19 12:45:28 UTC
SVN commit 1013226 by dfaure:

Giuseppe Della Bianca is completely right, this should be path(), not toLocalFile(). Wrong Windows porting...
Fix will be in 4.3.1.
BUG: 204322


 M  +1 -1      jobuidelegate.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1013226