Bug 203462 - Switching panel form horizontal to vertical layout doesn't update pager layout
Summary: Switching panel form horizontal to vertical layout doesn't update pager layout
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-pager (show other bugs)
Version: unspecified
Platform: Fedora RPMs Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 20:42 UTC by Mathias Panzenböck
Modified: 2010-06-12 13:33 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Panzenböck 2009-08-11 20:42:35 UTC
Version:            (using KDE 4.3.0)
Installed from:    Fedora RPMs

The desktop switch cube animation uses the panel's formfactor to determine whether the cube should be rotated horizontal or vertical. However, when you move the panel from one screen edge to another and thus change its formfactor the desktop switch animation stays the same. You need to relogin to update the effects rotation direction.

Further it seems that KDE has an idea about the cube or the layout of the virtual desktops. You can assign global hotkeys for "switch one desktop to the left" and such. This also seems to depend on the panel's formfactor and also gets not updated.
Comment 1 Martin Flöser 2009-08-11 20:48:44 UTC
I do not really get it. You change the panel from horizontal to vertical? In that case the pager layout changes but cube and all other kwin functionality changes the way as before?

If that's the case, we have to reassign to Plasma as KWin should fetch the change. You can try by manually chaning the number of rows.
Comment 2 Mathias Panzenböck 2009-08-11 21:12:00 UTC
It seems that the pager layout depends on the panel's layout and that the desktop effect and hotkeys for switching desktop to left/right depend on the pager's layout. However, when you move the panel from the bottom screen edge to the left screen edge the hotkeys and the desktop effect do not change; only on relogin they change. (The same is true for moving the panel from the left edge to the bottom edge. I didn't check other edge combinations.)
Comment 3 Martin Flöser 2009-08-11 21:31:13 UTC
In that case it's a Plasma issue. When the panel changes layout from horizontal to vertical the visual pager representation is changed, but _NET_DESKTOP_LAYOUT seems not to be adjusted
Comment 4 Rémy Greinhofer 2010-01-04 16:48:17 UTC
I could reproduce this behavior using KDE SC 4.3.4.
Comment 5 Marcel Schaal 2010-02-15 23:04:05 UTC
It's still in KDE SC 4.4.0.

I had a look at the code and there's a function call to update the desktop layout (kde 4.4.0: kdebase/workspace/plasma/desktop/applets/pager/pager.cpp:468). Is it possible, that the pager doesn't get the ownership for "_NET_DESKTOP_LAYOUT_S$screenID"?
Comment 6 Marco Martin 2010-06-12 13:33:36 UTC
SVN commit 1137323 by mart:

force to recalculate rows/columns when the formfactor changes
BUG:203462


 M  +2 -0      pager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137323