Bug 202822 - kmail config dialog: "Defaults" is not recognised as changing settings
Summary: kmail config dialog: "Defaults" is not recognised as changing settings
Status: RESOLVED WORKSFORME
Alias: None
Product: kmail
Classification: Applications
Component: GUI (show other bugs)
Version: 1.12.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2009-08-06 17:32 UTC by Christoph
Modified: 2012-01-08 16:57 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph 2009-08-06 17:32:47 UTC
Version:           1.12.0 (using KDE 4.3.0)
OS:                Linux
Installed from:    Ubuntu Packages

In kmails configuration dialog, clicking "Defaults" isn't recognized as changing anything: the "Apply" button is still grayed out and clicking "Ok" doesn't save the loaded default settings.
But: if anything else is manually changed in the config dialog, kmail notices this and ungrays the "Apply" buttons and all changes are saved normally (even those loaded by the "Defaults" button).
Comment 1 Martin Koller 2009-08-07 23:27:34 UTC
can confirm also with 4.4 trunk
Comment 2 Nicolas L. 2010-04-27 12:10:18 UTC
valid on kde 4.4.2
Comment 3 Nicolas L. 2010-04-27 12:34:19 UTC
if this is a junior job, i will try to fix it
Comment 4 Björn Ruberg 2010-04-27 13:18:51 UTC
I think it is a junior job. Probably just a signal configChanged() missing.
Comment 5 Nicolas L. 2010-04-27 13:52:12 UTC
in fact after more tests it appears to work correctly here and when default change a value, Apply is enabled.

But a question appear to me: 

Is it normal that some checkboxes never changes when clicking default ?

for ex here, the if i check the box for "Beep", clicking on default doesn't not uncheck and if the box is unchecked,  default doesn't check it.
Comment 6 Björn Ruberg 2010-04-27 13:54:40 UTC
Sounds as if the "setBackToDefault" is not complete and does not unset options that have been added after it was written. You may check that.
Comment 7 Christophe Marin 2012-01-08 16:57:02 UTC
Cannot reproduce with master. Pressing defaults on config pages previously changed activates the apply button. Closing