Bug 202495 - dr. konqui should autologin in bugs.kde.org
Summary: dr. konqui should autologin in bugs.kde.org
Status: RESOLVED FIXED
Alias: None
Product: drkonqi
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 14:59 UTC by m.wege
Modified: 2019-07-02 11:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description m.wege 2009-08-04 14:59:57 UTC
Version:            (using KDE 4.2.98)
Installed from:    Ubuntu Packages

dr. konqui should autologin in bugs.kde.org if the logindata is stored in kwallet. Or at least make it a choice, it is not as if many people have more then one bugs.kde.org-account. Right now the manuall login-click is one to much.
Comment 1 FiNeX 2009-08-04 16:02:58 UTC
I'd like this feature too :-)
Comment 2 Dario Andres 2009-08-04 20:14:16 UTC
I should analyze it and figure out how to implement the feature:
Because if you already do autologin, but you want to use another account, you should get a way to stop the automatic login to happen.

BTW: I have just commited a change in 4.4 to reduce in 1click the steps on the Login page. (once you click "Login" and you start the session properly, the page is turned automatically..., you don't have to click Next)
Comment 3 Dario Andres 2009-10-24 03:42:53 UTC
Any ideas of how to implement this in an unobtrusive way (timers are not allowed by HIG I think ...)
Comment 4 m.wege 2009-10-24 04:01:04 UTC
How about just loging in and then "Logged in as [Name]" and "Klick here, if you want to login with a different Username" -> This is used on Amazon and other sites and I think it is a good way.
Comment 5 Elias Probst 2011-01-13 16:26:55 UTC
I like the suggestion made in comment#4.
Would love to see this implemented.
Comment 6 Harald Sitter 2019-07-02 11:39:34 UTC
Git commit add2ad75e3625c5b0d772a555ecff5aa8bde5c22 by Harald Sitter.
Committed on 02/07/2019 at 11:27.
Pushed by sitter into branch 'Plasma/5.16'.

auto log in if username and password have been loaded from kwallet

Summary:
it's a bit moot to load the data from the wallet and then still have the
user manually click a log in button when we could just as well have tried
to log in using the stored credentials.

the new behavior is that the user goes through the bug reporting dialog,
and when showing the login page it will automatically try to login using
stored credentials. if the creds check out, the dialog automatically moves
on to the next page.

- page-validity is now in a helper canLogin function as it needs checking
  in two functions now (walletlogin and loginclick)
- the page now automatically goes into login state and attempts to log in
  using stored credentials

in the event that the credentials are wrong (e.g. password changed on
website) the page will enter error state saying the credentials are wrong.
when no credentials are in the wallet or the credentials are incomplete
(password remembering is off) no auto login happens.
FIXED-IN: 5.16.3
CHANGELOG: DrKonqi will now automatically log into bugs.kde.org when possible

Test Plan:
- have no credentials -> no auto login
- login manually and store credentials -> restart -> auto login happens
- change password on website -> restart -> auto login fails & error is shown

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22190

M  +23   -6    src/bugzillaintegration/reportassistantpages_bugzilla.cpp
M  +2    -0    src/bugzillaintegration/reportassistantpages_bugzilla.h

https://commits.kde.org/drkonqi/add2ad75e3625c5b0d772a555ecff5aa8bde5c22