Bug 202414 - allow to hide status bar and toolbar
Summary: allow to hide status bar and toolbar
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 18:37 UTC by Maciej Pilichowski
Modified: 2017-06-06 17:09 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 17.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-08-03 18:37:26 UTC
Version:            (using KDE 4.2.98)

Please add another entry to "view" menu -- "show status bar" (the bar at the bottom of the window), "show toolbar". Currently I try to squeeze every pixel from the screen but I only have choice -- fullscreen or normal view with statusbar, toolbar which takes space and I don't use them.
Comment 1 Jekyll Wu 2012-01-03 02:41:43 UTC
You can hide the toolbar by right clicking the menubar and unchecking "Main Toolbar".
Comment 2 Kai Uwe Broulik 2012-01-03 13:56:36 UTC
Right, but there should be an option in a convenient and consistent location.
Comment 3 Fest 2013-01-14 19:06:35 UTC
*** This bug has been confirmed by popular vote. ***
Comment 4 andydecleyre 2016-10-19 02:06:42 UTC
Seven years later, I'd still love to hide that bottom bar. I would no matter the size, but I especially do because it's enormous for a status bar.
Comment 5 un4tt3nd3d 2017-03-02 05:50:33 UTC
Was surprised that this can't be done. It is very important for an image viewer to be able to take the focus away from itself and put it on the picture.
Comment 6 Valerio Pilo 2017-03-02 18:28:23 UTC
Submitted https://phabricator.kde.org/D4799 for review.
Comment 7 andydecleyre 2017-03-02 18:41:49 UTC
(In reply to Valerio Pilo from comment #6)
> Submitted https://phabricator.kde.org/D4799 for review.

I'm not sure that's the right link, or if this is the issue you're looking for.
Comment 8 Christoph Feck 2017-03-02 20:12:40 UTC
Valerio submitted https://phabricator.kde.org/D4901 (and did not add any reviewers :)
Comment 9 andydecleyre 2017-03-02 20:30:46 UTC
Woo!
Comment 10 Valerio Pilo 2017-03-03 09:40:22 UTC
Thanks Christoph! Being new to phabricator sucks :) I'll commit within tomorrow.
Comment 11 Valerio Pilo 2017-03-03 10:38:05 UTC
Fixed in master, 04f2546
Comment 13 andydecleyre 2017-04-25 03:08:11 UTC
I don't believe this is truly resolved. The original report from 2009 specified that there ought to be an item in the view menu for these two actions. This is not the case, and there are a couple of problems with that:

1) It is unexpected to have the view-statusbar action located in the settings submenu, because that's a view checkbox, just like the view-sidebar action, which lives in the view submenu, naturally.

2) Since no menu item or settings widget was added at all for the hide-toolbar action, it is still impossible for users to hide the toolbar if they happen to be using app-menu-in-titlebar, as the only way to find the option is to right-click the nonexistent app menu bar.
Comment 14 andydecleyre 2017-04-25 17:18:57 UTC
Another reason this solution is incomplete is that if you want the statusbar hidden (always), you must to go to the app menu, the settings submenu, and click on the hide-statusbar option -- every single time gwenview is opened.

I don't know whether the same is true for the toolbar-hiding, as I have appmenu-in-titlebar, so I don't have the toolbar-hide feature.
Comment 15 Christoph Feck 2017-04-27 12:25:43 UTC
According to the patch, the status bar visibility setting should get saved.
Comment 16 andydecleyre 2017-04-28 17:51:54 UTC
(In reply to Christoph Feck from comment #15)
> According to the patch, the status bar visibility setting should get saved.

Well it doesn't in 17.04.0. Unless someone else is experiencing it differently?
Comment 17 Valerio Pilo 2017-05-01 07:41:09 UTC
Confirmed, the status is not saved. I will fix the persistence and move the entry to the View menu (I agree it's a better fit, maybe with a shortcut like F6 or the like).
Comment 18 andydecleyre 2017-05-01 16:11:22 UTC
(In reply to Valerio Pilo from comment #17)
> Confirmed, the status is not saved. I will fix the persistence and move the
> entry to the View menu (I agree it's a better fit, maybe with a shortcut
> like F6 or the like).

Thank you. Can you please also add a menu entry for showing/hiding the toolbar (and make sure that's persistent as well)? I believe that falls within the scope of this bug.
Comment 19 andydecleyre 2017-05-11 23:02:42 UTC
Can this issue please be kept open until it's resolved?
Comment 20 Valerio Pilo 2017-05-14 15:50:01 UTC
I've submitted https://phabricator.kde.org/D5854 (to fix the statusbar persistence) and https://phabricator.kde.org/D5855 (to add the toolbar menu entry).

I've used standard KDE Actions, so they will end up in the Settings menu like in all other apps. Perhaps we should move the Sidebar menu entry there as well, for the sake of consistency.
Comment 21 null 2017-05-16 22:48:05 UTC
> Perhaps we should move the Sidebar menu entry there as well, for the sake of consistency.

The current location of the sidebar menu entry is not ideal if only looking at Gwenview, but for the sake of consistency with other applications I'd actually keep them as is (e.g. Dolphin and Kate have theirs split similarly between "View" and "Settings"). On the other hand, Okular is a counterexample.

Could we base the placement decision on other characteristics (e.g. "View" menu for content related entries, "Settings" menu for everything relating to chrome)? Unfortunately, that's also not very clear-cut in this case.

Let's just keep it as is, as to not confuse users with mysteriously moving menu entries.
Comment 22 andydecleyre 2017-05-16 23:00:59 UTC
If an interface has a top level View menu, and menu items which toggle the visibility of interface elements, and those menu items are not under View, it is not sane, no matter how many other interfaces are not sane.
Comment 23 Valerio Pilo 2017-05-17 10:59:59 UTC
I agree with you Andy, but it's a change that has to be planned and done desktop-wide. Propose it!
Comment 24 Valerio Pilo 2017-05-31 07:34:40 UTC
Both changes, persistency and shortcut, were pushed to Applications/17.04 . Cheers!
Comment 25 andydecleyre 2017-06-06 17:09:02 UTC
(In reply to Valerio Pilo from comment #23)
> I agree with you Andy, but it's a change that has to be planned and done
> desktop-wide. Propose it!

If you're interested, proposed over at https://bugs.kde.org/show_bug.cgi?id=380901