Bug 202072 - MGI::positions() isn't const, positivePosition() reinterpretation
Summary: MGI::positions() isn't const, positivePosition() reinterpretation
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR wishlist
Target Milestone: 0.8 (KDE 4.3)
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 13:02 UTC by Torsten Rahn
Modified: 2009-08-01 11:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Rahn 2009-07-31 13:02:17 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

Currently the positions() method isn't a const getter. 

We might want to change this.

In related matters the ScreenGraphicsItem::positions method already reinterpretes the negative position as a positive one (which I feel should maybe better be done in AbstractFloatItem itself, so that it's still possible to create ScreenGraphicsItems that are partially out of the viewport ).

Also as another suggestion by ariya we might consider using alignment properties instead of the current implementation. However this might introduce additional complexity, so this should be discussed.
Comment 1 jensmh 2009-08-01 11:17:54 UTC 
Fixed in svn revision 1005225.