Bug 202002 - Filter bar doesn't filter files with "+" pattern
Summary: Filter bar doesn't filter files with "+" pattern
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 15:21 UTC by FiNeX
Modified: 2010-01-07 20:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2009-07-30 15:21:14 UTC
Suppose to have some files with a "+" on the filename. If you try to filter them out using the filter bar and typing "+", nothing is shown.

Reproduced in current trun r1004092
Comment 1 Frank Reininghaus 2009-07-30 18:47:20 UTC
The reason is that the view does not filter the files/folders using the actual contents of the filter bar, but it interprets the filter as a regular expression. "+" has a special meaning in regular expressions, which is why you need to enter "\+" in the filter bar to filter items containing it.

This is not really obvious, I think ;-) It could be changed by changing

m_proxyModel->setFilterRegExp(nameFilter);

to

m_proxyModel->setFilterFixedString(nameFilter);

in DolphinView::setNameFilter(const QString& nameFilter).

But on the other hand, it might be that some users rely on regular expressions for advanced filtering, so I don't know if this should really be changed or not.
Comment 2 Peter Penz 2010-01-07 20:28:32 UTC
SVN commit 1071258 by ppenz:

allow filtering for filenames having a +

BUG: 202002

 M  +1 -1      dolphincolumnview.cpp  
 M  +1 -1      viewextensionsfactory.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071258
Comment 3 Peter Penz 2010-01-07 20:29:59 UTC
SVN commit 1071261 by ppenz:

Backport of SVN commit 1071258: allow filtering for filenames having a +

CCBUG: 202002

 M  +1 -1      dolphincolumnview.cpp  
 M  +1 -1      viewextensionsfactory.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071261