Bug 201591 - Restart queue in Batch queue manager
Summary: Restart queue in Batch queue manager
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: BatchQueueManager-Workflow (show other bugs)
Version: 1.0.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-26 23:09 UTC by Michal Thoma
Modified: 2016-07-04 05:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.2.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Thoma 2009-07-26 23:09:31 UTC
Version:           1.0b3 (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

I'm missing possibility to restart precessed or half processed queue in Batch queue manager.

For example I want to change some settings durig the que processing. I stop the queue and want to process all images again. Now I can only clear queue and reload all images to queue manager again.

Or I process images with some setting and then I want to process same images with different settings again (i. e. thumbnail a full size images for web gallery). Again the restart queue be would be useful.
Comment 1 caulier.gilles 2010-03-11 15:20:00 UTC
Jens,

If i'm not too wrong, i remember that you is interrested to implement this feature in BQM (dixit an IRC talk). right ?

Gilles Caulier
Comment 2 Jens Mueller 2010-03-11 20:40:20 UTC
Yes, that's true. I put it on my TODO list (and it is still there), but havent produced something useful yet. Below is a comment from me on the mailing list:

"Looking for bug #201591 it would be nice to reset proccessed items when 
assigned tools or assigned tools settings to one queue changed. 
There is already a signal 'signalAssignedToolsChanged', but this signal is 
also called when switching beetween queues, and for every tool that is started 
in running mode. I don't see why 'signalAssignedToolsChanged' should be 
signaled to a queue in both cases at all. Next, if move a tool up or down this 
signal is called twice."

Reevaluate the above shows that this is still true. I will have a second look at it.
Comment 3 Jens Mueller 2010-03-11 21:16:56 UTC
SVN commit 1102096 by jmueller:

do not emit signalAssignedToolsChanged when BQM current queue changes

CCBUGS:  201591

 M  +0 -2      assignedlist.cpp  
 M  +3 -0      queuemgrwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1102096
Comment 4 caulier.gilles 2010-03-11 22:26:47 UTC
Jens,

About your commit #1102096, take a care :

- if you change something in assigned tool list, using drag and drop to change tools order for ex, or to add new tool in list, the list of tool play is right.

- if you change tool settings, this one is played right.

In both case, use console debug messages.

If i remember, The list of assigned tools and the settings for each tools is hosted in the Queue instance. So all changes must be dispatched to it, before to play in batch.

Gilles Caulier
Comment 5 Jens Mueller 2010-03-11 22:46:57 UTC
Gilles,

I only removed the emit of the signal in assignedlist when current queue changes (and create a new connection to update statusbar). I don't know if you just want to give me a 'take care' hint (which i adopt) or if you find something broken now?

Jens
Comment 6 caulier.gilles 2010-03-11 22:49:11 UTC
(:=))) no, i don't have tested your changes. I just want to be sure that not all is broken there... regression tests, as usual...

Gilles
Comment 7 Jens Mueller 2010-03-12 23:47:24 UTC
SVN commit 1102593 by jmueller:

do not emit signalAssignedToolsChanged when executing a tool and reset state of queue items after tool changes (settings, position, add, remove)

BUGS: 201591

 M  +2 -1      NEWS  
 M  +1 -1      utilities/queuemanager/basetools/color/autocorrection.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/bcgcorrection.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/bwconvert.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/channelmixer.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/colorbalance.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/curvesadjust.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/hslcorrection.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/iccconvert.cpp  
 M  +1 -1      utilities/queuemanager/basetools/color/whitebalance.cpp  
 M  +1 -1      utilities/queuemanager/basetools/convert/convert2jp2.cpp  
 M  +1 -1      utilities/queuemanager/basetools/convert/convert2jpeg.cpp  
 M  +1 -1      utilities/queuemanager/basetools/convert/convert2pgf.cpp  
 M  +1 -1      utilities/queuemanager/basetools/convert/convert2png.cpp  
 M  +1 -1      utilities/queuemanager/basetools/convert/convert2tiff.cpp  
 M  +1 -1      utilities/queuemanager/basetools/decorate/watermark.cpp  
 M  +1 -1      utilities/queuemanager/basetools/enhance/blur.cpp  
 M  +1 -1      utilities/queuemanager/basetools/enhance/localcontrast.cpp  
 M  +1 -1      utilities/queuemanager/basetools/enhance/noisereduction.cpp  
 M  +1 -1      utilities/queuemanager/basetools/enhance/restoration.cpp  
 M  +1 -1      utilities/queuemanager/basetools/enhance/sharpen.cpp  
 M  +1 -1      utilities/queuemanager/basetools/filters/filmgrain.cpp  
 M  +1 -1      utilities/queuemanager/basetools/metadata/assigntemplate.cpp  
 M  +1 -1      utilities/queuemanager/basetools/transform/flip.cpp  
 M  +1 -1      utilities/queuemanager/basetools/transform/resize.cpp  
 M  +1 -1      utilities/queuemanager/basetools/transform/rotate.cpp  
 M  +6 -1      utilities/queuemanager/batchtool.cpp  
 M  +1 -0      utilities/queuemanager/batchtool.h  
 M  +12 -0     utilities/queuemanager/queuelist.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1102593