Bug 199617 - When clicking on "My Tags", the view switches automatically after 2 seconds
Summary: When clicking on "My Tags", the view switches automatically after 2 seconds
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 1.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 23:40 UTC by Andi Clemens
Modified: 2012-06-27 11:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.0.0


Attachments
A quickfix for this issue (1.38 KB, patch)
2009-07-10 15:48 UTC, Andi Clemens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Clemens 2009-07-09 23:40:13 UTC
Version:           1.0.0-beta3 (using 4.2.4 (KDE 4.2.4), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.30-ARCH

Click on tag folderview, then on the topmost tag (My Tags).
It will display the welcome screen.

But then digiKam either opens some random image or movie after 2 seconds.
Comment 1 Andi Clemens 2009-07-10 15:48:19 UTC
Created attachment 35222 [details]
A quickfix for this issue

This patch fixes the issue.
I disabled these connections and still the view seems to behave like it should.
Filtering works as well as adding and removing images.
Why do we need those connections?

When I change to a tag folder, these connections are called over 100 times, with a single click!
This seems to be wrong in my eyes, looks like some race-condition.
Maybe this would also explain the flickering some people seem to encounter.

Marcel,
could it be that these connections are done in another way somewhere else in the code?
Right now I see no malfunction when removing them.

Andi
Comment 2 Andi Clemens 2009-07-10 15:51:35 UTC
Hmm no the "selectionChanged" connection needs to be active, otherwise the edit button is disabled.
But then I have the issue again that was described in the original report.
Comment 3 Andi Clemens 2009-07-10 17:05:40 UTC
Ok I found the problem.
Somehow if the tag album root is used, we try to display this root album, in a recursive way.
This is why we see the welcome page and then some images after a second.

I will commit a little patch now, hope this is the right place where the problem should be fixed.

Andi
Comment 4 Andi Clemens 2009-07-10 17:07:53 UTC
SVN commit 994420 by aclemens:

Do not start a list job if the album is a root album.
This prevents the tag view to display all tags recursively, if "tag
subalbums" option is set.

BUG:199617

 M  +3 -0      imagealbummodel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=994420