Bug 199520 - Do not show brightness controls if the modules allowing it are not properly installed (empty /sys/class/backlight/)
Summary: Do not show brightness controls if the modules allowing it are not properly i...
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-battery (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 08:39 UTC by Dima Ryazanov
Modified: 2010-08-03 21:36 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Ryazanov 2009-07-09 08:39:25 UTC
Version:            (using KDE 4.2.90)
OS:                Linux
Installed from:    Ubuntu Packages

When I move the brightness slider in the Power Management applet, the screen brightness doesn't actually change.

Most likely, I don't have the right drivers: "lshal" doesn't mention brightness, and /sys/class/backlight/ is empty. If that's the case, the applet shouldn't show the brightness widget.
Comment 1 Dima Ryazanov 2009-07-09 09:39:07 UTC
Just wanted to confirm: I was missing the drivers, and it works correctly after I installed them.
Still, I think it's a bug that the slider is there when the drivers are missing.
Comment 2 Dario Andres 2009-07-09 22:08:08 UTC
What do you mean by "drivers" ? Which ones? some kernel modules related to power ?
Thanks
Comment 3 Dima Ryazanov 2009-07-09 22:15:04 UTC
Yes, I was missing the "nvidia_bl" kernel module.
Comment 4 Rafał Miłecki 2010-07-30 00:11:30 UTC
I've this implemented locally for KDE 4.4.4. Just have to checkout trunk and port my patch.
Comment 5 Aaron J. Seigo 2010-07-30 00:36:49 UTC
Rafał: awesome :) can you post the resulting patch to reviewboard.kde.org when you do so? (or you could just post the patch as-is to plasma-devel if you aren't going to get to the porting-to-trunk anytime soon)
Comment 6 Rafał Miłecki 2010-08-01 00:40:51 UTC
SVN commit 1157703 by rmilecki:

Drop unused Battery::setFullBrightness()
CCBUG: 199520


 M  +0 -6      battery.cpp  
 M  +0 -1      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1157703
Comment 7 Rafał Miłecki 2010-08-01 01:36:33 UTC
SVN commit 1157711 by rmilecki:

Backport 1157703: drop unused Battery::setFullBrightness()
This is needed for bug 199520 fix.
CCBUG: 199520


 M  +0 -6      battery.cpp  
 M  +0 -1      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1157711
Comment 8 Rafał Miłecki 2010-08-01 01:44:43 UTC
SVN commit 1157714 by rmilecki:

Control any amount of brightness devices

Ship it! by Sebastian Kügler:
http://reviewboard.kde.org/r/4796/

GUI:
BUG: 199520


 M  +46 -23    battery.cpp  
 M  +8 -3      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1157714
Comment 9 Rafał Miłecki 2010-08-01 01:49:09 UTC
SVN commit 1157716 by rmilecki:

Backport 1157714: Control any amount of brightness devices

Ship it! by Sebastian Kügler:
http://reviewboard.kde.org/r/4796/

GUI:
BUG: 199520
FIXED-IN: 4.5.0


 M  +46 -23    battery.cpp  
 M  +8 -3      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1157716
Comment 10 Sebastian Kügler 2010-08-03 21:29:07 UTC
SVN commit 1158799 by sebas:

Revert r1157716: control amount of brightness sliders

This patch produces 4 sliders on my machine (thinkpad T60).

As 4 sliders on OK machines are worse than 1 slider We have to  revert it
for now until we find a proper solution for it. I don't see anything I'd
happily commit to the stable branch, so I'll backport this one and we'll
let the bug in until we have something that works *and* doesn't break
machines that are otherwise OK.

CCBUG:199520
CCMAIL:zajec5@gmail.com

 M  +23 -46    battery.cpp  
 M  +3 -8      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1158799
Comment 11 Sebastian Kügler 2010-08-03 21:36:33 UTC
SVN commit 1158800 by sebas:


    Revert r1157716: control amount of brightness sliders
    
    This patch produces 4 sliders on my machine (thinkpad T60).
    
    As 4 sliders on OK machines are worse than 1 slider We have to  revert it
    for now until we find a proper solution for it. I don't see anything I'd
    happily commit to the stable branch, so I'll backport this one and we'll
    let the bug in until we have something that works *and* doesn't break
    machines that are otherwise OK.
    
    CCBUG:199520
    CCMAIL:zajec5@gmail.com

Dirk, any way we can get this one into 4.5.0 still? (It was about time that I'd 
be the one coming with last minute screw-ups and asking everybody to re-roll. 
Sorry, really. :/)

CCMAIL:release-team@kde.org


 M  +23 -46    battery.cpp  
 M  +3 -8      battery.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1158800