Bug 199461 - picture quickinfo doesn't show isospeed
Summary: picture quickinfo doesn't show isospeed
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Metadata-Engine (show other bugs)
Version: 0.10.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 19:44 UTC by Ulf Dietrich
Modified: 2017-08-13 15:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.5.0
Sentry Crash Report:


Attachments
Screenshot from no quickinfo from isospeed (65.90 KB, image/png)
2009-07-08 19:45 UTC, Ulf Dietrich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ulf Dietrich 2009-07-08 19:44:34 UTC
Version:           0.10.0 (using 4.2.4 (KDE 4.2.4), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.28-13-generic

The quickinfo doesn't show the isospeed from my Nikon D50 files. Not the *.nef or *.jpg.
Please let me know, if you need original files.

I attached a screenshot. There can you see, that the information in the file is exist. 

Thanks
Comment 1 Ulf Dietrich 2009-07-08 19:45:41 UTC
Created attachment 35164 [details]
Screenshot from no quickinfo from isospeed
Comment 2 caulier.gilles 2009-07-08 19:52:38 UTC
You look ISO value from nikon makernotes. this is not standard Exif value.

The value given in tooltip is taken from standard Exif...

Question : why Nikon makernotes value exist ? Which one is the good value.

In all case : Exif values is standardized. This is the reference value which will use for that. Are you sure that Nikon values is right. Perhaps it's a decoding problem with Exiv2 and Nikon makernotes parser (Markernote are not documented, not standardized, and use a private format).

Try to use Exiftool to compare this value with Exiv2. Look which one is right.

Gilles Caulier
Comment 3 Ulf Dietrich 2009-07-08 20:42:04 UTC
Thanks for that fast answer, but i can not find any information to the isospeed in the digikam EXIF part.

Where is the place where i have to look to give you the information that you need?

In my part i can say, that the nikon part is right. It shows the information to the isospeed like the time i take the pictures.

Ulf
Comment 4 Mikolaj Machowski 2009-07-08 21:29:55 UTC
Nikon plays dirty with users by removing some vital info from official standards and using them only in proprietary Makernotes This caused some brouhaha few years ago when they started this practice.

Now this is question what digiKam should do? It shows this value but in another place, basic functionality is provided.

Make some workaround `if ( maker == "NIKON" ) { Exif-ISO = NIKON-ISO }` ?

How far should that go - apply only to interface (tooltips, properties panel) or "fix" this by filling proper Exif ISO field?
Comment 5 Andreas Huggel 2009-07-09 02:45:31 UTC
There is Exiv2 functionality to help with such cases, introduced in 0.18.1. ISO Speed is only one example for this mess. Have a look at the links below and it will be quite clear.

http://www.exiv2.org/doc/easyaccess_8hpp.html
http://dev.exiv2.org/repositories/entry/exiv2/trunk/src/easyaccess.cpp?rev=1760

Andreas
Comment 6 caulier.gilles 2009-07-09 08:17:08 UTC
Thanks Andreas,

I have already some wrappers like this in digiKam and libkexiv2. For exemple, About ISO speed :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#511

...where makernotes are not yet parsed as in Exiv2 :

http://dev.exiv2.org/repositories/entry/exiv2/trunk/src/easyaccess.cpp?rev=1760#L78

Mik, a patch is very easy to do...

Gilles
Comment 7 caulier.gilles 2009-07-20 13:15:50 UTC
Marcel,

I can see redondant code everywhere in DMetadata. For ex. :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#541

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#1162

We need really to factorize code...

Gilles
Comment 8 caulier.gilles 2011-12-16 16:08:14 UTC
Git commit f8e878cbc287741f8e7aee3e345ab49d057ba613 by Gilles Caulier.
Committed on 16/12/2011 at 17:07.
Pushed by cgilles into branch 'master'.

new wrapper to extract ISO speed info from more tags, especially makernotes
BUGS: 199461

M  +65   -21   libs/dmetadata/dmetadata.cpp
M  +4    -1    libs/dmetadata/dmetadata.h

http://commits.kde.org/digikam/f8e878cbc287741f8e7aee3e345ab49d057ba613