Version: (using KDE 4.2.2) OS: Linux Installed from: Ubuntu Packages GPS correlator should allow the user to set a time difference in seconds between the camera and UTC + time zone to correct wrongly set time in the camera. At the moment, it offers only time zone selection. The reasoning is that quite often, the clock in camera is not very precise and instead of setting it every time it is easier to take a picture of the GPS device with displayed time and later simply calculate the difference between EXIF time and displayed time of GPS.
Created attachment 37171 [details] additional user offset in mins and secs I've created a patch that allows specifying and additional user offset with minutes and seconds.
Isn't it better to link this to the time adjust plugin? Reimplementing this feature feels a bit like a duplication of effort.
How exactly do you think of this. To my mind this is mostly some gui work and using the whole gui of the time adjust plugin looks too complicated for this task in my opinion.
Well, it just doesn't seem logical to me to not correct the photo times when you know they are wrong. My workflow is that I first correct the faulty photo times (with the time and date adjust plugin) and then use the correct time to match them to the GPS tracks. It could be as simple as just adding a button labeled "Correct camera clock offset" or something similar that opens the time adjust plugin.
But it's a user decision which workflow to use and I can also understand this workflow. As long as the camera date is only off a few seconds I wouldn't either change the exif time (which means touching all files two times: one time for changing the date and one time for adding the gps position. For my large raw format this is really a time consuming task). Sometimes I also like playing with the offset until I think the positions fit best to the photos. Therefore it's really handy to have this offset option directly in the dialog to adjust it correlate, re-adjust, correlate... and so on. For me this was also one missing feature why I always used another tool for this task and not digikam.
Johannes, Pieter, Let's me introduce a way, not yet implemented in digiKam/libkipi/kipi-plugins, but that i would to code in the future... In digiKam, go to Batch Queue Manager. On the bottom/right, just near History/Custom Tool/Base Tools, i would to add Kipi Tools view. Now, you can feel the power of BQM : You make a list of kipi tools to apply, as GPSSync and AdjustTime to a set of items. No need to dupplicates features in kipi tools, like you need currently. To export kipi-plugins as BQM tool, we need to patch libkipi to export core plugins action + plugins settings widget for configuration. Plugins need to be adapted accordingly. In digiKam BQM Batch Tools Manager need to be patched to queries all kipi tools and create proper BQM tools instance accordingly. It's not a simple task, sure, but very usefull for end users. We will talking about in details at Coding Sprint, and if you like the idea, start to implement something like that... Gilles Caulier
This sounds like a good idea, but I'm a bit afraid that novices won't find this feature then. I also had to search some time until I found out what I can to with the batch queue manager and how to use it efficiently. So to me this seems mainly like a GUI problem. Maybe we could add a menu to the menu bar that provides quick access to pre-programmed tool sets in the batch queue manager and that is customizable for advanced users. This is one of the main problems I see for the usability of the bqm. Also, with the way you describe, we would have to think about a solution how to display the elected coordinates per image directly (as text and in a map)?
>Also, with the way you describe, we would have to think about a solution how to >display the elected coordinates per image directly (as text and in a map)? By this way, only specific task can be exported to BQM, especially Batch process. For GPSSync, nothing can be done with map, but to synchronize item with a GPX file is possible. Gilles
(In reply to comment #8) > >Also, with the way you describe, we would have to think about a solution how to > >display the elected coordinates per image directly (as text and in a map)? > > By this way, only specific task can be exported to BQM, especially Batch > process. For GPSSync, nothing can be done with map, but to synchronize item > with a GPX file is possible. But isn't that the important point? Selecting the date offset, correlating and checking the positions on a map and if it doesn't fit, re-adjusting and so on?
Well, for your workflow, certainly. But with BQM, only batch process can be integrated. No part where user need to set someting for each item individualy... Gilles
I didn't mean to set something per image. Just the ability to view the assigned location on a map quickly after correlation but before writing the exif data. Otherwise there would be the same problem of wasting time with writing locations that potentially need to be readjusted.
I can understand Johannes argument. In fact I used to do that myself before I figured out that it is easier to make a picture of my GPS unit displaying the time and use that photo to work out the clock delta, which is now implemented in the date and time adjust tool. Maybe it is better to do it the following way (just brainstorming here): 1. Create time offset fields (hours, minutes and seconds) in the correlator window. The correlator takes the values from this field into account when calculating the points. 2. Create a button that summons the reference photo window from the time and date adjust plugin. It doesn't change exif times, but just fills in the data fields from point 1. 3. Make a checkbox "adjust metadata times". When it is checked, not only the GPS coordinated are written to the metadata, but the timestamp is also corrected. Anyway, I think the GUI of the correlator is long overdue for a redesign (see bug #195944), but this way would mean relatively little change. The only big drawback is that a class from another plugin has to be called.
I would vote for the proposal of Johannes: x to set the default time offset as per GPS vs Exif x have the possibility to see on the map where the location per each image is x have the possibility to update image metadata and file date&time with the corrected time x and run it at once for all the images in the queue. As I understand, BQM does not support such a workflow, so a re-worked GUI for the correlator would be an option. The requirement for visual feedback on the map is that GPS correlation often results in error (well, it is even in its name) due to missing saved track points (bad signal, too large time gap, etc.).
SVN commit 1056472 by mghansen: Fix handling of timezones for the camera time. Handle timezones automatically if the timezone of the camera is the same as the timezone of the system. Also, add the possibility to adjust the camera time offset in seconds for now using the patch by Johannes Wienke. BUG: 214210 CCBUG: 199189 M +2 -1 NEWS M +22 -12 gpssync/gpsdataparser.cpp M +4 -3 gpssync/gpsdataparser.h M +130 -20 gpssync/gpssyncdialog.cpp M +1 -0 gpssync/gpssyncdialog.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1056472
Please test current implementation from svn. I would to know if patch solve the problem and if this entry can be added to NEWS file as well for the release. I plan to make tarball tomorow. Thanks in advance for your help Gilles Caulier
Thanks for the patch, the fine time offset seems to work for me. (1.0.0-rc tarball)