Bug 199107 - make the popupDialog of group in tasks applet hide automatically
Summary: make the popupDialog of group in tasks applet hide automatically
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-06 07:27 UTC by 潘卫平
Modified: 2009-07-27 12:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
popup dialog shows with konsole' tooltip (126.38 KB, image/png)
2009-07-06 10:54 UTC, 潘卫平
Details
the problem is the same (194.09 KB, image/png)
2009-07-06 10:56 UTC, 潘卫平
Details
make the popup dialog of group hide automatically (5.88 KB, patch)
2009-07-06 11:26 UTC, 潘卫平
Details
the patch above has side effect, fix it (5.95 KB, patch)
2009-07-06 12:00 UTC, 潘卫平
Details
the popup dialog shows with tooltips (140.46 KB, image/png)
2009-07-09 12:10 UTC, 潘卫平
Details
the popup dialog shows with tooltips (206.24 KB, image/png)
2009-07-09 12:11 UTC, 潘卫平
Details
the popup dialog shows with context menu (162.96 KB, image/png)
2009-07-09 12:12 UTC, 潘卫平
Details
the popup dialog shows with tooltips (198.02 KB, image/png)
2009-07-09 12:13 UTC, 潘卫平
Details
the popup dialog shows with context menu (it was covered) (163.20 KB, image/png)
2009-07-09 12:15 UTC, 潘卫平
Details
hide the popup automatically, but less annoying (2.45 KB, patch)
2009-07-10 15:39 UTC, 潘卫平
Details

Note You need to log in before you can comment on or make changes to this bug.
Description 潘卫平 2009-07-06 07:27:54 UTC
Version:            (using Devel)
Compiler:          svn r 991963 
OS:                Linux
Installed from:    Compiled sources


reproduce steps:
1、set "By Program Name" grouping strategy, uncheck "Only when the taskbar is full"
2、open one konsole application
3、open two dolphin applications, they will group together
4、click the dolphin group, a dialog will show
5、move the mouse over konsole, a tooltip will show with the dialog together, the dialog doesn't hide automatically.

And if you move the mouse out of the dialog, the dialog won't hide automatically.

I think that we should make popupDialog of group hide automatically, seems to be more intelligent.
Comment 1 Aaron J. Seigo 2009-07-06 10:31:09 UTC
i think you really need to include some screenshots or screencasts that show the problem, as i am not sure what you are referring to. :/
Comment 2 潘卫平 2009-07-06 10:54:56 UTC
Created attachment 35083 [details]
popup dialog shows with konsole' tooltip

The mouse moves to konsole, but popup dialog of dolphin is still there.
Comment 3 潘卫平 2009-07-06 10:56:43 UTC
Created attachment 35084 [details]
the problem is the same
Comment 4 潘卫平 2009-07-06 11:26:02 UTC
Created attachment 35085 [details]
make the popup dialog of group hide automatically

When the mouse move out of the popup dialog of group, and it isn't hovering on the group, I let the dialog hide automically.
Comment 5 潘卫平 2009-07-06 12:00:04 UTC
Created attachment 35092 [details]
the patch above has side effect, fix it
Comment 6 潘卫平 2009-07-07 13:47:07 UTC
Let me try to explain the bug and patch clearly.

The bug is about plasma applet tasks. I found a problem that the popup dialog of a group can't hide automically.

Repruduce steps:
1、set "By Program Name" grouping strategy, and uncheck "Only when the taskbar is full".
2、run one konsole application
3、run two dolphin applications, they will group together on the taskbar.
4、click the dolphin group, a popup dialog will show.
5、move the mouse over konsole on the taskbar, a tooltip will show, but
the popup dialog of dolphin doesn't hide automatically. It is still there! see  Comment #2 

And now the tooltip of konsole and the popup dialog of dolphin show together, and side by side. I think that we should make the popup dialog of dolphin group hide automatically when it receives a hoverLeaveEvent, make it seem to be more intelligent.
Comment 7 潘卫平 2009-07-09 12:07:43 UTC
I found that this problem is more complicated than I expected. 
First, the popup dialog of group shows together with plasma tooltips.
Second, It shows together with context menu.
Third, the popup dialog, tooltip and context menu may belongs to different applets.
Comment 8 潘卫平 2009-07-09 12:10:53 UTC
Created attachment 35183 [details]
the popup dialog shows with tooltips
Comment 9 潘卫平 2009-07-09 12:11:56 UTC
Created attachment 35184 [details]
the popup dialog shows with tooltips
Comment 10 潘卫平 2009-07-09 12:12:46 UTC
Created attachment 35185 [details]
the popup dialog shows with context menu
Comment 11 潘卫平 2009-07-09 12:13:35 UTC
Created attachment 35186 [details]
the popup dialog shows with tooltips
Comment 12 潘卫平 2009-07-09 12:15:20 UTC
Created attachment 35187 [details]
the popup dialog shows with context menu (it was covered)
Comment 13 潘卫平 2009-07-10 15:39:25 UTC
Created attachment 35221 [details]
hide the popup automatically, but less annoying

I still think that hiding the popup automatically is more convenient than rejecting showing tooltip and context menu.

Since AbstractTaskItem has a m_applet pointer, I add a function to hide the popup dialog in class Tasks. Every time a WindowTaskItem or a TaskGroupItem wants to show a tooltip or a context menu, it first calls that function to hide the popup dialog which is showing.
Comment 14 潘卫平 2009-07-27 12:13:01 UTC
SVN commit 1002921 by peterpan:

reject showing tooltips when the popup dialog is showing.

BUG:199107


 M  +9 -0      taskgroupitem.cpp  
 M  +15 -1     tasks.cpp  
 M  +3 -3      tasks.h  
 M  +32 -12    windowtaskitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002921