Bug 198978 - colors setting dialogue is way too wide
Summary: colors setting dialogue is way too wide
Status: RESOLVED WORKSFORME
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_colors (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Matthew Woehlke
URL:
Keywords: investigated, triaged
: 189123 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-07-05 06:24 UTC by Andrey Borzenkov
Modified: 2018-10-27 01:59 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
kcmshell4 --lang en_GB colors (82.06 KB, image/png)
2009-07-06 20:05 UTC, Andrey Borzenkov
Details
kcmshell4 --lang ru_RU colors (92.14 KB, image/png)
2009-07-06 20:06 UTC, Andrey Borzenkov
Details
Screenshot showing the problem (70.29 KB, image/png)
2009-07-12 20:30 UTC, Albert Astals Cid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Borzenkov 2009-07-05 06:24:51 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

KDE 4.2.95

kcmshell colors is very wide; so that when it is embedded in system settings, I need to scroll far right to find scroll bar. There does not appear to be any text that long inside.

See screenshot https://qa.mandriva.com/attachment.cgi?id=13237 in Mandriva bug https://qa.mandriva.com/show_bug.cgi?id=49850.
Comment 1 Matthew Woehlke 2009-07-06 19:50:03 UTC
Doesn't happen here, maybe upstream or Qt bug?

Also read: since it doesn't appear to be directly my fault, no promises fixing it; help much appreciated!
Comment 2 Andrey Borzenkov 2009-07-06 20:05:02 UTC
Created attachment 35099 [details]
kcmshell4 --lang en_GB colors
Comment 3 Andrey Borzenkov 2009-07-06 20:06:30 UTC
Created attachment 35100 [details]
kcmshell4 --lang ru_RU colors

Let me guess - you are using en as default language? Compare two screen shots (with different language settings).
Comment 4 Matthew Woehlke 2009-07-06 21:00:16 UTC
Hmm, that's... interesting. (I trust you checked all tabs for obnoxiously long strings?)

Yes, I'm using en_US. I'm not saying it's not a bug; it seems obvious that it is indeed a bug. Just that I likely won't be able to dig into it personally. (Also, nothing jumps out at me why it would be this kcm in particular having problems; my guess would be that the size hinting code somewhere is broken.)
Comment 5 Albert Astals Cid 2009-07-08 03:28:02 UTC
Andrey can you look at the lists and see if there's a very long item in any of the lists that makes it that big?
Comment 6 Anne-Marie Mahfouf 2009-07-12 15:07:40 UTC
It also happens in French and I cannot find any long string. It seems a layout problem of some sort but I could not find which one.
Comment 7 Albert Astals Cid 2009-07-12 20:01:26 UTC
Well, it must be somewhere in the translations, min width with french here is 1024 pixels, in catalan is 800
Comment 8 Albert Astals Cid 2009-07-12 20:29:41 UTC
The problem is on the translations of third tab, preview items for when example the pallete is window are too wide, you may want to think of a different way of representing them
Comment 9 Albert Astals Cid 2009-07-12 20:30:40 UTC
Created attachment 35256 [details]
Screenshot showing the problem
Comment 10 Anne-Marie Mahfouf 2009-07-13 11:09:50 UTC
Albert, in comment #8 do you mean we translators?
Comment 11 Anne-Marie Mahfouf 2009-07-13 12:46:56 UTC
SVN commit 995758 by annma:

Wouldn't a comment in the .ui file like "translators: keep those as short as possible" be in order to keep the kcm width acceptable? 
To the French team: this should probably be forwarded to trunk translations which I don't have a checkout for right now.
CCBUG=198978
CCMAIL=kde-francophone@kde.org


 M  +9 -9      kcmcolors.po  


WebSVN link: http://websvn.kde.org/?view=rev&revision=995758
Comment 12 Pino Toscano 2009-07-13 13:04:22 UTC
Another solution could be expand the "+ - !" etc signs into words (ie "positive", "negative", etc, with a context for the i18n() string), and splitting the example frame in two lines of text.
This way, even longer translations could make the kcm less wide.
Comment 13 Albert Astals Cid 2009-07-13 13:59:36 UTC
@annma: I mean the developers of course. Their current layouting is just targeted at english and languages with "small" words and so it has the bug of not being easily translatable.
Comment 14 Matthew Woehlke 2009-07-13 20:07:29 UTC
All I can come up with to change on my end would be make the whole thing take more rows (Pino, I guess that is what you suggested?). But why not drop all the "text en", etc.? Or, as annma suggested, just make the text shorter (it could be abbreviated easily)? It's desirable to be able to match up what is what, and to be a few letters (because otherwise you can't tell how well it works), but e.g. "text ayant le focus" is really overkill ("focus" should be more than sufficient!).

@Albert: what color scheme is that? If it's one we ship, I need to fix the neutral text color ASAP as it is horribly illegible.
Comment 15 Albert Astals Cid 2009-07-13 20:12:27 UTC
The theme is my current one, no idea where it came from but i think it's none of the shipped ones.
Comment 16 Matthew Woehlke 2009-07-13 20:21:10 UTC
Hehe... well it's probably honeycomb :-), and... my bad. That's hover, not neutral (used to neutral being yellow). Since that is a decoration color, not a text color, a: it doesn't need as high contrast, and b: one should never be using it as a tint anyway. And it looks fine as hover color.

I'll fix that; hover and focus can be stacked, and without the tinted backgrounds. That will make things a tiny bit smaller, at least.
Comment 17 Matthew Woehlke 2009-07-13 20:39:19 UTC
SVN commit 996037 by mwoehlke:

color kcm: Remove focus/hover background preview

While it's not "illegal" to use background-tinted-to-decoration, there is no requirement that this color contrast with the unmodified decoration color. Therefore, change the set preview to not imply that this is the case. (Technically, it doesn't even need to contrast well enough for legible text.)

Noticed thanks to an attachment in the referenced bug, and, while this doesn't fix said bug, it makes it slightly less broken due to one fewer item in the long row.

CCBUG: 198978


 M  +106 -131  setpreview.ui  
 M  +0 -6      setpreviewwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=996037
Comment 18 Christoph Feck 2009-07-30 16:30:22 UTC
*** Bug 189123 has been marked as a duplicate of this bug. ***
Comment 19 Christoph Feck 2011-07-22 18:13:54 UTC
Is this still a problem with any of the KDE provided languages?
Comment 20 Christoph Feck 2011-12-21 17:01:34 UTC
If you can provide the information requested in comment #19, please add it.
Comment 21 Andrew Crouthamel 2018-09-22 01:51:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 22 Andrew Crouthamel 2018-10-27 01:59:13 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!