Bug 198943 - systemsettings' "desktop theme details" section does not apply changes in themes
Summary: systemsettings' "desktop theme details" section does not apply changes in themes
Status: RESOLVED DUPLICATE of bug 224240
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_desktopthemedetails (show other bugs)
Version: unspecified
Platform: Ubuntu Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-04 19:52 UTC by greatbunzinni
Modified: 2010-04-06 14:35 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description greatbunzinni 2009-07-04 19:52:27 UTC
Version:           4.2.95 (using KDE 4.2.90)
Installed from:    Ubuntu Packages

After a recent upgrade from Kubuntu's KDE 4.3 ppa repository, systemsettings' "desktop theme details" section didn't made it possible to apply theme changes. For example, if I change the panel background the "apply" button is enabled but if I change the entire theme through the theme drop-down menu the "apply" button stays disabled.
Comment 1 Anne-Marie Mahfouf 2009-07-06 09:35:39 UTC
yes, switching theme using the top left combobox is not working. Per Element switching is working correctly.
Comment 2 Anne-Marie Mahfouf 2009-07-06 15:50:13 UTC
In fact I had a look at the code and it looked to me that lots of code was missing to get this working so I thought probably that was me missing something ;) So I asked on IRC and pinda kindly checked it and explained me how this works: you can only design Customized themes. Choosing one in the drop down menu only allows you a start base for your customized theme. 

This is not intuitive at all from the GUI and should be redesigned in my opinion.
To the reporter: if you have a suggestion, please feel free to explain it.

CCing the kcm author in case I am wrong
Comment 3 Andrew Lake 2009-07-06 17:30:58 UTC
Anne-Marie is correct.  The kcm was never intended to provide a redundant path for changing the plasma theme. (In fact, it wouldn't be able to anyway since plasma does not provide any out-of-process hooks to change the plasma theme).  The drop list is only intended to select the base theme, the starting point from which to start customizing.  I previously provided help docs for the kcm that should have provided this info.  Perhaps it wasn't very clear? 

Maybe the droplist could be titled with some text describing it's function.  Something for 4.4 perhaps...
Comment 4 Aaron J. Seigo 2009-07-06 22:45:54 UTC
"In fact, it wouldn't be able to anyway since
plasma does not provide any out-of-process hooks to change the plasma theme"

that's actually not true anymore. just call Plasma::Theme::defaultTheme::setTheme(name) and, assuming you're using the global defaultTheme, all the plasma theme using apps will reload their theming.
Comment 5 greatbunzinni 2009-07-06 23:35:01 UTC
(In reply to comment #2)

> To the reporter: if you have a suggestion, please feel free to explain it.

When I upgraded KDE the default theme went from oxygen to air, which made me want to change it back to oxygen. After digging through systemsettings I've stumbled on the "Desktop theme details" section, which looked like the place to perform just that. The drop-down menu sure made it look like it was designed with that in mind, as switching between themes also made all the color scheme options change. The only problem is that it is impossible to apply the changes.

So, as users like me go to that spot with hopes of changing the desktop theme it would be nice if it was in fact possible to change the theme.
Comment 6 Anne-Marie Mahfouf 2009-07-07 09:58:20 UTC
Right click on your desktop and choose "Desktop Settings" and there you can change globally the Plasma Theme.
Comment 7 greatbunzinni 2009-07-07 15:28:56 UTC
(In reply to comment #6)
> Right click on your desktop and choose "Desktop Settings" and there you can
> change globally the Plasma Theme.

Great, that does it nicely.

Nonetheless, wouldn't it be better if there was a centralized spot where the user could not only select the plasma theme but also customize it as it is done in the "desktop theme details" section? It doesn't seem right to have have the same type of functionality (configuring plasma theme) in two separate, distinct places.
Comment 8 Andrew Schulman 2009-08-06 12:02:17 UTC
Gosh, this certainly is confusing.  I thought that all configuration was done in System Settings now.  Like others here, I looked all over System Settings for a place to choose and configure a Plasma theme, and thought I'd finally found it at Advanced > Desktop Theme Details... but nothing I changed there had any effect.

Maybe Desktop Settings > Appearance could be put into System Settings > Appearance > Desktop as well?

Thanks,
Andrew.
Comment 9 Dario Andres 2010-04-06 14:35:56 UTC

*** This bug has been marked as a duplicate of bug 224240 ***