Bug 198169 - Add bidirectional text support in default profile
Summary: Add bidirectional text support in default profile
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords: rtl
Depends on:
Blocks:
 
Reported: 2009-06-28 14:48 UTC by Zayed Al-Saidi
Modified: 2011-11-19 20:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8


Attachments
Summary: Konsole BiDi rendering enabled by default (886 bytes, patch)
2010-05-30 19:55 UTC, Ebrahim Mohammadi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zayed Al-Saidi 2009-06-28 14:48:36 UTC
Version:            (using KDE 4.2.3)
OS:                Linux
Installed from:    SuSE RPMs

All RTL languages need to activate the bidirectional text support in the Konsole by default. I suggest these solution:
1- The option "Enable Bi-Directional text rendering" should be checked in the default profile.

2- Add entry in the Language .desktop to decide the default profile.

3- Activate "Bi-Directional text rendering" dynamically depend on the if the application in RTL or LTR.

I prefer option 1 because it is simply but I do not know if the enabling Bi-Directional text rendering is costly on CPU or not.
Comment 1 Diego Iastrubni 2009-09-05 00:02:16 UTC
I disagree. If you do this, you will break console applications which have BiDi support. Well, I would not want to have this as default "for me" at least... :)
Comment 2 Zayed Al-Saidi 2009-09-05 15:36:51 UTC
@Diego:

Is there any console application that support BiDi by default? I think the majority of console applications luck BiDi support.
Comment 3 Ebrahim Mohammadi 2010-05-06 23:37:43 UTC
The standard way of handling BiDi text, according to Unicode, is the way Konsole works when BiDi is turned on. So I think it should be enabled by default.
And if somebody uses a non-standard application which handles BiDi in some other way, he can still turn off this part of standard.
On the other hand, as a Persian (RTL language) full-time Debian user for years, I haven't heard aobut any non-standard BiDi application yet. They might exist, but my point is they are rare if any.
Comment 4 Ebrahim Mohammadi 2010-05-30 19:55:55 UTC
Created attachment 47493 [details]
Summary: Konsole BiDi rendering enabled by default

Make Konsole BiDi rendering enabled by default. Default Shell.profile and also fallback profile are updated to have BidiRenderingEnabled set to true by default.
In reviewboard: http://reviewboard.kde.org/r/4181/
Comment 5 Kurt Hindenburg 2011-11-19 20:55:06 UTC
Git commit e718e93bf0caa524c99cd4578c1932db945a3d7f by Kurt Hindenburg.
Committed on 19/11/2011 at 21:46.
Pushed by hindenburg into branch 'master'.

Add bidirectional text support by default

Make Konsole BiDi rendering enabled by default. Default Shell.profile
and also fallback profile are updated to have BidiRenderingEnabled set
to true by default.
AFAIK there is no reason not to have it on by default.  I don't see
any penalty code-wise.
BUG: 198169
FIXED-IN: 4.8

M  +2    -1    data/profiles/Shell.profile
M  +1    -1    src/Profile.cpp

http://commits.kde.org/konsole/e718e93bf0caa524c99cd4578c1932db945a3d7f