Bug 198073 - Choosing "Back" In Tree View Mode Ignores Previous View
Summary: Choosing "Back" In Tree View Mode Ignores Previous View
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords: reproducible
Depends on:
Blocks:
 
Reported: 2009-06-27 19:44 UTC by David Rankin
Modified: 2009-11-14 16:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Rankin 2009-06-27 19:44:49 UTC
Version:            (using KDE 4.2.90)
Installed from:    SuSE RPMs


    When using konqueror File Management with tree view mode, if you navigate in the right-pane to the needed file and open the file in the embedded text editor, pressing the "Back" arrow takes you to the root of the tree shown in the right-pane instead of to your previous view where focus is on the file that you have just viewed in the embedded text editor.

    In other words, "exiting the embedded text editor in tree mode fails to restore the correct state and focus of the view in the right pane.

    This is unexpected behavior and very annoying behavior.

Example (3 screenshots):

  First navigate in "tree-view" mode to a sub-folder in the right-pane to a text file you want to view:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-tree-mode-800.jpeg

  Next open the file in the embedded text viewer (or any of the other embedded viewers):

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-tree-mode-1-800.jpeg

  Now press the "Back" arrow in the browser toolbar to exit the embedded viewer:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-tree-mode2-800.jpeg

    Crap! All of your open tree-view folders in the right-pane have been collapsed and you are back at the root of the right-pane instead of where you should be (~/linux/ati-compiz/ with focus on 'aticonfig-help')

    One possible bug causing the problem is the failure of kde4 konqueror to update the path shown in the address window as you navigate down the tree in the right pane. 

    kde3 properly handles this situation without any problem. Here is the exact same screenshot for kde3 konqueror after having pressed the "Back" arrow while viewing ~/linux/ati-compiz/aticonfig-help in the embedded editor:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-tree-mode2-kde3.jpeg

    This is broken behavior that needs to be fixed for 4.3. Thanks.
Comment 1 Frank Reininghaus 2009-06-28 02:05:19 UTC
Thanks for the bug report!

This is related bug 169886 (this is a Dolphin bug, note that Konqueror uses Dolphin's file management code in KDE 4.x). It might be though that a bit more work on the Konqueror/DolphinPart side is needed for the present case (going back from a different kind of KPart), I'm not sure about that.

> One possible bug causing the problem is the failure of kde4 konqueror to
> update the path shown in the address window as you navigate down the tree in
> the right pane. 

I'd say that this is intentional (and also just like in KDE 3): The location bar always contains the directory which is open in the view, i.e., the "root item" of the currently shown tree, which does not change when you navigate down the tree like in your first screenshot.

> This is broken behavior that needs to be fixed for 4.3. Thanks.

Well, this issue is not really easy to fix, I think. Note that much of the file-management code in KDE 4 has been rewritten from scratch, and the underlying Qt and kdelibs libraries changed quite much during the KDE 3 -> KDE 4 transition, so it's not possible to just copy&paste the old KDE 3 code that handled this :-(
Comment 2 David Rankin 2009-06-29 05:14:04 UTC
Whoa,

  This isn't intentional and it isn't the way it works in kde3. When you preview a file in kde3 konqueror, the files you are previewing retains the focus when the preview is closed so you are back where you started before selecting "Preview In" in the context menu.

    In kde4 konqueror, konqueror completely loses its memory of which file the focus was on before "Preview In" was selected.

    The bug is somewhat worse than I thought. I originally thought it was limited to the "tree view" display. Not so. This occurs regardless of whether you are in tree mode and it is annoying as hell. I was looking through screenshots trying to find a view with the broken kpager view with compiz a few minutes ago and every time I exited "Preview", I would end up with the focus at the top of the file list every time instead of back on the file I just previewed. Here is a screenshot of the list I was looking at in konqueror:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-loses-focus.jpeg

When exiting "Preview", the focus should remain on the file that was previewed and not be reset to the top of the list. When you have 500 files in the directory, it is a huge pain...

Let me know if I can send anything else. Thanks.
Comment 3 David Rankin 2009-06-29 16:46:38 UTC
I started kde3 and captured several screenshots to provide exact information to help with this bug. In kde3, no matter where you are in the file list within the right-pane of konqueror, after preview, konqeror correctly returns focus to the file that was previewed after the preview:

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-kde3-postpreview.jpg

http://www.3111skyline.com/download/openSUSE_bugs/kde4/screenshots/konqueror-back-kde3-postpreview1.jpg

Thanks.
Comment 4 Frank Reininghaus 2009-06-29 23:25:38 UTC
Thanks for the update. We have two different bugs here:

1. The DolphinPart inside Konqueror (and Dolphin itself) can't remember the state of the "Tree View" (this is bug 169886).

2. When going back to the DolphinPart inside Konqueror from another KPart, the state of the DolphinPart (including the currently selected file) is not restored.
Comment 5 David Rankin 2009-09-26 23:33:10 UTC
Any progress on this one? This bug is still present in "Version 4.3.1 (KDE 4.3.1) "release 165." It has got to be one of the most annoying bugs and really frustrates the use of "preview" in konqueror. If there is anything else I can provide that would help move this along, just let me know. Thanks.
Comment 6 Frank Reininghaus 2009-11-14 16:51:50 UTC
SVN commit 1049164 by freininghaus:

When navigating back/forward in the DolphinPart inside Konqueror, remember

1. the current item,
2. the scroll position of the view, and
3. the expansion state of the details view.

Before 3. can be implemented in Dolphin itself, some changes in
KUrlNavigator are required.

This fix will be in KDE 4.4.

BUG: 193549
BUG: 198073
BUG: 213137


 M  +1 -0      CMakeLists.txt  
 M  +46 -0     dolphindetailsview.cpp  
 M  +27 -0     dolphindetailsview.h  
 A             dolphindetailsviewexpander.cpp   [License: GPL (v2+)]
 A             dolphindetailsviewexpander.h   [License: GPL (v2+)]
 M  +12 -0     dolphinpart.cpp  
 M  +3 -0      dolphinpart.h  
 M  +129 -13   dolphinview.cpp  
 M  +35 -0     dolphinview.h  
 M  +4 -9      dolphinviewcontainer.cpp  
 M  +0 -6      dolphinviewcontainer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1049164