Bug 197904 - [PATCH] Cannot append to the end of the playlist by drag 'n drop
Summary: [PATCH] Cannot append to the end of the playlist by drag 'n drop
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.3-GIT
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 171016 175888 208483 209597 218339 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-26 00:35 UTC by Edward Karavakis
Modified: 2010-01-04 18:02 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screencast of the bug (408.42 KB, video/ogg)
2009-06-26 00:37 UTC, Edward Karavakis
Details
Fix for appending to the end of the playlist by drag'n drop (2.73 KB, patch)
2009-10-09 01:14 UTC, Alexey Chernov
Details
Updated version Alexey Chernov that applies cleanly with current git head (2.82 KB, patch)
2009-11-22 20:34 UTC, Ivo Anjo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Edward Karavakis 2009-06-26 00:35:35 UTC
Version:           2.1.1 (using KDE 4.2.90)
OS:                Linux
Installed from:    Ubuntu Packages

Cannot append a music folder to the *end* of the playlist by drag 'n dropping using nautilus. I can perfectly append it to any other part of the playlist but not at the end - after the last track on the playlist.
Comment 1 Edward Karavakis 2009-06-26 00:37:35 UTC
Created attachment 34815 [details]
Screencast of the bug
Comment 2 Myriam Schweingruber 2009-07-11 16:17:29 UTC
Confirmed with Dolphin, 2.2-SVN r 994561, Kubuntu 9.04, KDE 4.2.95
Comment 3 Myriam Schweingruber 2009-08-20 15:50:17 UTC
*** Bug 175888 has been marked as a duplicate of this bug. ***
Comment 4 Myriam Schweingruber 2009-08-20 15:55:15 UTC
There already is a workaround for this:

1. Open the file browser in Amarok
2. Right click on the track you want to append
3. Select "Append to playlist"

This works flawlessly everytime, regardless how long the playlist is.

If you absolutely need to use an external file browser:

1. drag to the second last position
2. drag the last track to second last position
there you go :)
Comment 5 anton 2009-08-23 19:45:10 UTC
There are many situations when it is not comfortable to use internal amarok file browser - for example I have inserted cd disk/flash drive and dolphin window is opened from device notifier plasmoid. It is natural to drag files from the opened dolphin window and not to navigate again to the same folder from amarok.

And actually full-featured dolphin would be always more comfortable for navigation than amarok internal browser.

The issue is not critical, but a bit annoying - yesterday I felt that when needed to construct playlist from many files located in different folders on filesystem. Vote for this bug.
Comment 6 Alexey Chernov 2009-08-29 13:11:16 UTC
Well, it's so strange. This bug is serious UI fault if we call it properly. It makes considerable part of playlist management impossible (not only inserting from browser, but also regrouping existing tracks inside playlist). The item _should be_ able to be inserted to the end of playlist, because it's logically follows the possibility to insert to other positions. It's really unclear to me why this bug is still there since 2.0 beta states and has so low priority.
Comment 7 Myriam Schweingruber 2009-08-29 15:03:47 UTC
(In reply to comment #6)
> Well, it's so strange. This bug is serious UI fault if we call it properly. It
> makes considerable part of playlist management impossible (not only inserting
> from browser, but also regrouping existing tracks inside playlist). The item
> _should be_ able to be inserted to the end of playlist, because it's logically
> follows the possibility to insert to other positions. It's really unclear to me
> why this bug is still there since 2.0 beta states and has so low priority.

What about contributing if you know so much about development priorities? Ranting will certainly not make this go faster...
Comment 8 Alexey Chernov 2009-08-29 16:24:18 UTC
Thanks for your advice, but it's so hard to with such things about bug reports :) I don't know about development priorities but I can say about my (user) priority and that's what I wrote about. I really didn't want ranting or posting any complaints - I just wanted to point out to the important bug which persists for a very long time and is almost ignored.
Comment 9 Myriam Schweingruber 2009-08-29 17:12:24 UTC
Alexey, JFYI: we don't ignore bugs, if it were so, there wouldn't be a single comment from our side here, and there are at least 4 :)

Subscribing Nikolaj as this is his field.
Comment 10 Alexey Chernov 2009-08-30 14:46:31 UTC
OK, thank you. It's better that i'm wrong in this case :)
Comment 11 Nikolaj Hald Nielsen 2009-08-30 19:05:30 UTC
I will have a look at it...

It's not that I don't _want_ to solve every single bug in here immediately, but unfortunately my experiments with creating a clone army and/or extending the day to 35 hours are not progressing too well at the moment.

I will try to find the time to have a look at this one... at some point...
Comment 12 Myriam Schweingruber 2009-09-02 17:22:36 UTC
*** Bug 171016 has been marked as a duplicate of this bug. ***
Comment 13 Myriam Schweingruber 2009-09-25 14:04:44 UTC
*** Bug 208483 has been marked as a duplicate of this bug. ***
Comment 14 Mikko C. 2009-10-06 07:46:03 UTC
*** Bug 209597 has been marked as a duplicate of this bug. ***
Comment 15 Myriam Schweingruber 2009-10-06 08:32:20 UTC
typos can be funny sometimes :)
Comment 16 Alexey Chernov 2009-10-09 01:12:49 UTC
I seem to manage to fix the problem after some digging. Could you please test it and maybe it's appropriate to apply it to the trunk?
The patch is for 2.2.0 release branch.
Comment 17 Alexey Chernov 2009-10-09 01:14:59 UTC
Created attachment 37460 [details]
Fix for appending to the end of the playlist by drag'n drop
Comment 18 Andy Kelley 2009-10-09 06:03:26 UTC
No promises on when I will have time to test this. When I catch up enough at
work and on homework I like to work on LMMS.

On Thu, Oct 8, 2009 at 4:15 PM, Alexey Chernov <4ernov@gmail.com> wrote:

> https://bugs.kde.org/show_bug.cgi?id=197904
>
>
>
>
>
> --- Comment #17 from Alexey Chernov <4ernov gmail com>  2009-10-09 01:14:59
> ---
> Created an attachment (id=37460)
>  --> (http://bugs.kde.org/attachment.cgi?id=37460)
> Fix for appending to the end of the playlist by drag'n drop
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
Comment 19 Myriam Schweingruber 2009-11-11 10:33:19 UTC
Andy, could you please make a merge request on Gitorious at http://gitorious.org/amarok so the devs can have a look at the patch?
Comment 20 Ivo Anjo 2009-11-22 20:34:34 UTC
Created attachment 38504 [details]
Updated version Alexey Chernov that applies cleanly with current git head

I've just tested the patch and it works nicely: I was able to successfully drag to the bottom of the playlist, and other drags seem unaffected, and still work fine.

Attached is Alexey's patch corrected to apply cleanly to current git.
Comment 21 Alexey Chernov 2009-11-22 20:45:05 UTC
Ivo, thank you for your corrections and good words. Hope it will be merged.
Comment 22 Myriam Schweingruber 2009-11-23 19:27:23 UTC
(In reply to comment #20)
> Created an attachment (id=38504) [details]
> Updated version Alexey Chernov that applies cleanly with current git head
> 
> I've just tested the patch and it works nicely: I was able to successfully drag
> to the bottom of the playlist, and other drags seem unaffected, and still work
> fine.
> 
> Attached is Alexey's patch corrected to apply cleanly to current git.

Ivo, please make a merge request to Gitorious, as described in Comment #19
Comment 23 Mikko C. 2009-12-12 08:32:20 UTC
*** Bug 218339 has been marked as a duplicate of this bug. ***
Comment 24 Ivo Anjo 2010-01-03 23:07:00 UTC
I think this is fixed in git now, without this patch. Using amarok "2.2.1.90" from the opensuse build service I can now append to the end of the playlist.
Comment 25 Myriam Schweingruber 2010-01-04 18:02:57 UTC
(In reply to comment #24)
> I think this is fixed in git now, without this patch. Using amarok "2.2.1.90"
> from the opensuse build service I can now append to the end of the playlist.

Closing then, thanks for the feeback :)