Bug 197316 - Two ways to do a simple zooming
Summary: Two ways to do a simple zooming
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Canvas (show other bugs)
Version: 1.0.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-20 21:34 UTC by Domas Jokubauskis
Modified: 2017-08-07 08:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0
Sentry Crash Report:


Attachments
An example with highlighted zoom controls (123.35 KB, image/png)
2009-06-20 21:34 UTC, Domas Jokubauskis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Domas Jokubauskis 2009-06-20 21:34:22 UTC
Created attachment 34692 [details]
An example with highlighted zoom controls

In digikam album view the zoom controls are in the status bar. However, in "Image Editor" window these controls are in the toolbar. I believe that if both zoom controls would be the same and in the status bar, digikam would feel more solid and easier to use.

Also, I think that same zoom controls in Gwenview are simpler and more powerful.
Comment 1 Marcel Wiesweg 2009-11-29 15:38:57 UTC
That's also something to keep in mind for the new editor widget?
Comment 2 caulier.gilles 2009-12-24 13:18:59 UTC
Yes of course Marcel...

Gilles Caulier
Comment 3 caulier.gilles 2010-01-20 12:20:43 UTC
SVN commit 1077548 by cgilles:

Editor Tool Preview factoring : Important change here
- Now editor tool based on image region widget preview can be zommed to 100% all time. there is no zomming 
restriction based on image size to always fit contents to preview size.
- When user select a zommable editor tool, canvas zoom is applied to preview.
- All preview mode are available with image region widget tools based (NR, refocus, etc...)

Warnings: this commit do not finalize preview factoring and regressions tests need to be done again. 
I can see preview dysfunctions in some cases.

TODO : port progressively all editor tools based on image guide widget (not zommable) to image region widget (zommable) as WB, curves, levels, etc...

BUGS: 221987
BUGS: 163284
BUGS: 148072
BUGS: 222975
CCBUGS: 197316
CCBUGS: 148235
CCBUGS: 220567
CCBUGS: 196469
CCBUGS: 221988



 M  +5 -0      canvas/canvas.cpp  
 M  +1 -0      canvas/canvas.h  
 M  +7 -4      editor/editortooliface.cpp  
 M  +24 -54    widgets/imageregionwidget.cpp  
 M  +4 -7      widgets/imageregionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1077548
Comment 4 caulier.gilles 2010-01-28 15:44:05 UTC
SVN commit 1081508 by cgilles:

prepare the future : add DZoomBar widget. Will be used later to solve #197316
CCBUGS: 197316


 M  +3 -2      CMakeLists.txt  
 AM            dzoombar.cpp   [License: GPL (v2+)]
 AM            dzoombar.h   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=1081508
Comment 5 caulier.gilles 2010-01-29 13:54:34 UTC
SVN commit 1081965 by cgilles:

Image Editor : move zoom action from tool bar to status bar. Use new DZoomBar widget.
Now editor has the same usability about zoom action than other digiKam parts, as Light Table or Preview 
BUGS: 197316


 M  +73 -9     libs/widgets/common/dzoombar.cpp  
 M  +5 -2      libs/widgets/common/dzoombar.h  
 M  +10 -0     utilities/imageeditor/canvas/canvas.cpp  
 M  +3 -0      utilities/imageeditor/canvas/canvas.h  
 M  +1 -7      utilities/imageeditor/editor/digikamimagewindowui.rc  
 M  +58 -0     utilities/imageeditor/editor/editorstackview.cpp  
 M  +8 -1      utilities/imageeditor/editor/editorstackview.h  
 M  +23 -68    utilities/imageeditor/editor/editorwindow.cpp  
 M  +0 -2      utilities/imageeditor/editor/editorwindow.h  
 M  +3 -7      utilities/imageeditor/editor/editorwindow_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1081965
Comment 6 caulier.gilles 2010-01-29 13:56:27 UTC
Note : 

After 1.1.0 release, i plan to use DZoomBar instead StatusZoomBar everywhere.

Gilles Caulier