Bug 196839 - Overflow in bytes accouting in kppplogview
Summary: Overflow in bytes accouting in kppplogview
Status: RESOLVED FIXED
Alias: None
Product: kppp
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Harri Porten
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-17 07:06 UTC by Lamarque V. Souza
Modified: 2009-07-25 20:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Use 64-bit variables instead of 32-bit to count bytes (3.94 KB, patch)
2009-06-17 17:32 UTC, Lamarque V. Souza
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lamarque V. Souza 2009-06-17 07:06:29 UTC
Version:            (using KDE 4.2.4)
Compiler:          gcc version 4.3.2 Gentoo 4.3.2-r3 p1.6, pie-10.1.5
OS:                Linux
Installed from:    Gentoo Packages

kppplogbiew uses int to count bytes in and out in a session and to sum up bytes in and out during a month, when any of those variables reaches 2 GB an overflow happens.
Comment 1 Lamarque V. Souza 2009-06-17 17:32:14 UTC
Created attachment 34608 [details]
Use 64-bit variables instead of 32-bit to count bytes

This patch fix the problem for me.
Comment 2 Lamarque V. Souza 2009-07-06 17:37:59 UTC
Any news about when this patch can be added to KDE? I hope it can be added to 4.3 since it does not change strings, so no problem for the translation team. I have been using it for some weeks and everything is ok here.
Comment 3 Lamarque V. Souza 2009-07-09 21:38:29 UTC
SVN commit 993951 by lvsouza:

kppplogview uses int to count bytes in and out in a session and to sum up bytes
in and out during a month, when any of those variables reaches 2 GB an overflow
happens. This patch changes variable types from 32-bit to 64-bit.
BUG: 196839


 M  +3 -3      loginfo.cpp  
 M  +3 -3      loginfo.h  
 M  +11 -11    monthly.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=993951
Comment 4 Lamarque V. Souza 2009-07-25 19:48:39 UTC
SVN commit 1002338 by lvsouza:

Backport r993951 by lvsouza from trunk to the 4.2 branch:

kppplogview uses int to count bytes in and out in a session and to sum up bytes
in and out during a month, when any of those variables reaches 2 GB an overflow
happens. This patch changes variable types from 32-bit to 64-bit.
CCBUG: 196839



 M  +3 -3      loginfo.cpp  
 M  +3 -3      loginfo.h  
 M  +11 -11    monthly.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002338
Comment 5 Lamarque V. Souza 2009-07-25 20:00:16 UTC
SVN commit 1002341 by lvsouza:

Backport r993951 by lvsouza from trunk to the 4.3 branch:

kppplogview uses int to count bytes in and out in a session and to sum up bytes
in and out during a month, when any of those variables reaches 2 GB an overflow
happens. This patch changes variable types from 32-bit to 64-bit.
CCBUG: 196839



 M  +3 -3      loginfo.cpp  
 M  +3 -3      loginfo.h  
 M  +11 -11    monthly.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002341